split port_util.h off of net_util.h

split port_util.h off of net_util.h

BUG=488531
TBR=nick@chromium.org,msw@chromium.org

Committed: https://crrev.com/9ab6484eaaa89cbe90c182ac3f53f52593151ec4
Cr-Commit-Position: refs/heads/master@{#339612}

[eroman, 2015-07-15 23:08:52]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 23:10:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230313005/1

[eroman, 2015-07-15 23:22:38]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 23:23:28]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

(exceeded global retry quota)

[commit-bot: I haz the power, 2015-07-15 23:23:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230313005/20001

[eroman, 2015-07-15 23:24:40]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2015-07-15 23:25:04]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[commit-bot: I haz the power, 2015-07-15 23:25:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230313005/40001

[commit-bot: I haz the power, 2015-07-15 23:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 23:42:10]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

(exceeded global retry quota)

[mmenke, 2015-07-16 15:07:58]

LGTM, modulo header nits.

https://codereview.chromium.org/1230313005/diff/60001/net/base/host_port_pair.cc
File net/base/host_port_pair.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/base/host_port_pair...
net/base/host_port_pair.cc:13: #include "net/base/net_util.h"
What's net util needed for in this file?

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util.cc
File net/base/port_util.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util.cc#n...
net/base/port_util.cc:7: #include <iterator>
Do we ever explicitly include iterator?  Worth noting that net_util still uses
iterators over strings.  Seems weird to only include it here, unless I'm missing
something.

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util.cc#n...
net/base/port_util.cc:22: static const int kRestrictedPorts[] = {
Optional:  Could remove this static and the next while you're here, since
they're redundant.

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util.cc#n...
net/base/port_util.cc:101: g_explicitly_allowed_ports =
LAZY_INSTANCE_INITIALIZER;
Optional:  Know it was like this before...maybe move this just be moved into the
anonymous namespace, and you can get rid of the static?

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util_unit...
File net/base/port_util_unittest.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util_unit...
net/base/port_util_unittest.cc:13: std::string valid[] = {"", "1", "1,2",
"1,2,3", "10,11,12,13"};
include <string>?

https://codereview.chromium.org/1230313005/diff/60001/net/test/spawned_test_s...
File net/test/spawned_test_server/base_test_server.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/test/spawned_test_s...
net/test/spawned_test_server/base_test_server.cc:19: #include
"net/base/net_util.h"
What net_util method does this still use?

https://codereview.chromium.org/1230313005/diff/60001/net/test/spawned_test_s...
File net/test/spawned_test_server/spawner_communicator.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/test/spawned_test_s...
net/test/spawned_test_server/spawner_communicator.cc:16: #include
"net/base/net_util.h"
Again, not sure we still use net_util.

https://codereview.chromium.org/1230313005/diff/60001/net/url_request/ftp_pro...
File net/url_request/ftp_protocol_handler.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/url_request/ftp_pro...
net/url_request/ftp_protocol_handler.cc:9: #include "net/base/net_util.h"
Not using net_util

[eroman, 2015-07-21 01:04:04]

https://codereview.chromium.org/1230313005/diff/60001/net/base/host_port_pair.cc
File net/base/host_port_pair.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/base/host_port_pair...
net/base/host_port_pair.cc:13: #include "net/base/net_util.h"
On 2015/07/16 15:07:57, mmenke wrote:
> What's net util needed for in this file?

Done.

As an aside, do you know if we have include-what-you-use working for Chromium,
or some other automatic header fix-up tool?

Kind of tiresome to do these manually, and when I do I sometimes end up deleting
things that are being transitively included elsewhere, since I am just checking
that compilation still works  :)

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util.cc
File net/base/port_util.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util.cc#n...
net/base/port_util.cc:7: #include <iterator>
On 2015/07/16 15:07:57, mmenke wrote:
> Do we ever explicitly include iterator?  Worth noting that net_util still uses
> iterators over strings.  Seems weird to only include it here, unless I'm
missing
> something.

Removed.

(I had pruned the headers manually, and didn't quite catch everything)

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util.cc#n...
net/base/port_util.cc:22: static const int kRestrictedPorts[] = {
On 2015/07/16 15:07:57, mmenke wrote:
> Optional:  Could remove this static and the next while you're here, since
> they're redundant.

Done.

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util.cc#n...
net/base/port_util.cc:101: g_explicitly_allowed_ports =
LAZY_INSTANCE_INITIALIZER;
On 2015/07/16 15:07:57, mmenke wrote:
> Optional:  Know it was like this before...maybe move this just be moved into
the
> anonymous namespace, and you can get rid of the static?

Done.

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util_unit...
File net/base/port_util_unittest.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/base/port_util_unit...
net/base/port_util_unittest.cc:13: std::string valid[] = {"", "1", "1,2",
"1,2,3", "10,11,12,13"};
On 2015/07/16 15:07:57, mmenke wrote:
> include <string>?

Done.

https://codereview.chromium.org/1230313005/diff/60001/net/test/spawned_test_s...
File net/test/spawned_test_server/base_test_server.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/test/spawned_test_s...
net/test/spawned_test_server/base_test_server.cc:19: #include
"net/base/net_util.h"
On 2015/07/16 15:07:57, mmenke wrote:
> What net_util method does this still use?

Done.

https://codereview.chromium.org/1230313005/diff/60001/net/test/spawned_test_s...
File net/test/spawned_test_server/spawner_communicator.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/test/spawned_test_s...
net/test/spawned_test_server/spawner_communicator.cc:16: #include
"net/base/net_util.h"
On 2015/07/16 15:07:58, mmenke wrote:
> Again, not sure we still use net_util.

Done.

https://codereview.chromium.org/1230313005/diff/60001/net/url_request/ftp_pro...
File net/url_request/ftp_protocol_handler.cc (right):

https://codereview.chromium.org/1230313005/diff/60001/net/url_request/ftp_pro...
net/url_request/ftp_protocol_handler.cc:9: #include "net/base/net_util.h"
On 2015/07/16 15:07:58, mmenke wrote:
> Not using net_util

Done.

[eroman, 2015-07-21 02:34:48]

eroman@chromium.org changed reviewers:
+ msw@chromium.org, nick@chromium.org

[eroman, 2015-07-21 02:34:49]

TBR=nick,msw

msw:
  chrome/browser/ui/startup/startup_browser_creator.cc
nick:
  chrome/browser/sync/test/integration/sync_test.cc
  content/child/blink_platform_impl.cc
  content/renderer/pepper/pepper_websocket_host.cc
  content/renderer/render_thread_impl.cc

[mmenke, 2015-07-21 03:33:38]

LGTM

[mmenke, 2015-07-21 03:33:57]

On 2015/07/21 03:33:38, mmenke wrote:
> LGTM

Oops...forgot I signed off on it originally.

[eroman, 2015-07-21 05:02:42]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2015-07-21 05:02:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230313005/100001

[commit-bot: I haz the power, 2015-07-21 05:08:01]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-21 05:08:59]

Patchset 6 (id:??) landed as
https://crrev.com/9ab6484eaaa89cbe90c182ac3f53f52593151ec4
Cr-Commit-Position: refs/heads/master@{#339612}

[msw, 2015-07-21 17:18:41]

chrome/browser/ui/startup/startup_browser_creator.cc lgtm