Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230303003: Revert "Refactor current GAE abstraction library to be free of the SDK*" (Closed)

Created:
5 years, 5 months ago by iannucci
Modified:
5 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Revert "Refactor current GAE abstraction library to be free of the SDK*" This reverts commit a91c4ac2149f8bbe3711c4c662b6d500c9a8f799. CQ didn't validate that everything builds. Consequently, note everything builds :D. TBR=vadimsh@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/infra/+/92cee4406d23752a67bc01a2043f175f48114d23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3841 lines, -15029 lines) Patch
M go/.gitignore View 1 chunk +4 lines, -4 lines 0 comments Download
D go/src/infra/gae/libs/gae/brokenfeatures.go View 1 chunk +0 lines, -161 lines 0 comments Download
D go/src/infra/gae/libs/gae/brokenfeatures_test.go View 1 chunk +0 lines, -128 lines 0 comments Download
D go/src/infra/gae/libs/gae/context.go View 1 chunk +0 lines, -19 lines 0 comments Download
D go/src/infra/gae/libs/gae/doc.go View 1 chunk +0 lines, -62 lines 0 comments Download
D go/src/infra/gae/libs/gae/dummy.go View 1 chunk +0 lines, -175 lines 0 comments Download
D go/src/infra/gae/libs/gae/dummy_test.go View 1 chunk +0 lines, -85 lines 0 comments Download
D go/src/infra/gae/libs/gae/gae.infra_testing View 1 chunk +0 lines, -4 lines 0 comments Download
D go/src/infra/gae/libs/gae/globalinfo.go View 1 chunk +0 lines, -60 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/datastore.go View 1 chunk +0 lines, -77 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/datastore_impl.go View 1 chunk +0 lines, -509 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/datastore_key.go View 1 chunk +0 lines, -236 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/datastore_key_test.go View 1 chunk +0 lines, -241 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/datastore_test.go View 1 chunk +0 lines, -1688 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/generic_key.go View 1 chunk +0 lines, -84 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/helper.infra_testing View 1 chunk +0 lines, -4 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/internal/protos/datastore/README.md View 1 chunk +0 lines, -5 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/internal/protos/datastore/datastore.infra_testing View 1 chunk +0 lines, -4 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/internal/protos/datastore/datastore_v3.proto View 1 chunk +0 lines, -541 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/internal/protos/datastore/datastore_v3.pb.go View 1 chunk +0 lines, -2776 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/serialize.go View 1 chunk +0 lines, -335 lines 0 comments Download
D go/src/infra/gae/libs/gae/helper/serialize_test.go View 1 chunk +0 lines, -329 lines 0 comments Download
D go/src/infra/gae/libs/gae/mathrand.go View 1 chunk +0 lines, -42 lines 0 comments Download
D go/src/infra/gae/libs/gae/memcache.go View 1 chunk +0 lines, -79 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/README.md View 1 chunk +0 lines, -114 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/context.go View 1 chunk +0 lines, -168 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/datastore_query.go View 1 chunk +0 lines, -570 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/doc.go View 1 chunk +0 lines, -7 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/gkvlite_utils.go View 1 chunk +0 lines, -156 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/gkvlite_utils_test.go View 1 chunk +0 lines, -128 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/globalinfo.go View 1 chunk +0 lines, -51 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/memcache.go View 1 chunk +0 lines, -228 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/memcache_test.go View 1 chunk +0 lines, -213 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/memory.infra_testing View 1 chunk +0 lines, -4 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/plist.go View 1 chunk +0 lines, -298 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/plist_test.go View 1 chunk +0 lines, -392 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/raw_datstore.go View 1 chunk +0 lines, -155 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/raw_datstore_data.go View 1 chunk +0 lines, -475 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/raw_datstore_test.go View 1 chunk +0 lines, -591 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/taskqueue.go View 1 chunk +0 lines, -284 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/taskqueue_data.go View 1 chunk +0 lines, -270 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/taskqueue_test.go View 1 chunk +0 lines, -466 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/testing_utils_test.go View 1 chunk +0 lines, -115 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/context.go View 1 chunk +0 lines, -23 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/datastore_key.go View 1 chunk +0 lines, -82 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/doc.go View 1 chunk +0 lines, -7 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/globalinfo.go View 1 chunk +0 lines, -85 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/memcache.go View 1 chunk +0 lines, -156 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/prod.infra_testing View 1 chunk +0 lines, -3 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/raw_datastore.go View 1 chunk +0 lines, -156 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/raw_datastore_type_converter.go View 1 chunk +0 lines, -85 lines 0 comments Download
D go/src/infra/gae/libs/gae/prod/taskqueue.go View 1 chunk +0 lines, -150 lines 0 comments Download
D go/src/infra/gae/libs/gae/properties.go View 1 chunk +0 lines, -356 lines 0 comments Download
D go/src/infra/gae/libs/gae/properties_test.go View 1 chunk +0 lines, -165 lines 0 comments Download
D go/src/infra/gae/libs/gae/raw_datastore.go View 1 chunk +0 lines, -116 lines 0 comments Download
D go/src/infra/gae/libs/gae/taskqueue.go View 1 chunk +0 lines, -78 lines 0 comments Download
D go/src/infra/gae/libs/gae/taskqueue_testable.go View 1 chunk +0 lines, -22 lines 0 comments Download
D go/src/infra/gae/libs/gae/testable.go View 1 chunk +0 lines, -10 lines 0 comments Download
D go/src/infra/gae/libs/gae/upstream_errors.go View 1 chunk +0 lines, -109 lines 0 comments Download
D go/src/infra/gae/libs/gae/upstream_errors_test.go View 1 chunk +0 lines, -60 lines 0 comments Download
D go/src/infra/gae/libs/gae/upstream_types.go View 1 chunk +0 lines, -161 lines 0 comments Download
M go/src/infra/gae/libs/memlock/memlock.go View 4 chunks +16 lines, -13 lines 0 comments Download
M go/src/infra/gae/libs/memlock/memlock_test.go View 3 chunks +10 lines, -9 lines 0 comments Download
M go/src/infra/gae/libs/meta/eg.go View 2 chunks +13 lines, -7 lines 0 comments Download
M go/src/infra/gae/libs/meta/eg_test.go View 3 chunks +8 lines, -8 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/brokenfeatures.go View 6 chunks +22 lines, -26 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/brokenfeatures_test.go View 4 chunks +19 lines, -21 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/context.go View 1 chunk +5 lines, -6 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/datastore.go View 1 chunk +139 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/doc.go View 1 chunk +40 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/dummy.go View 8 chunks +63 lines, -53 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/dummy_test.go View 4 chunks +19 lines, -28 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/gae/commonErrors/commonErrors.infra_testing View 0 chunks +-1 lines, --1 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/gae/commonErrors/errors.go View 1 chunk +42 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/gae/context.go View 1 chunk +43 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/gae/datastore.go View 1 chunk +118 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/gae/doc.go View 1 chunk +2 lines, -2 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/gae/gae.infra_testing View 0 chunks +-1 lines, --1 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/gae/globalinfo.go View 4 chunks +21 lines, -19 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/gae/memcache.go View 1 chunk +111 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/gae/taskqueue.go View 1 chunk +68 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/globalinfo.go View 1 chunk +30 lines, -10 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/mathrand.go View 1 chunk +3 lines, -3 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memcache.go View 1 chunk +106 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/binutils.go View 1 chunk +98 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/binutils_test.go View 1 chunk +54 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/context.go View 5 chunks +5 lines, -5 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/datastore.go View 1 chunk +206 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/datastore_data.go View 17 chunks +137 lines, -135 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/datastore_query.go View 21 chunks +47 lines, -50 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/datastore_test.go View 13 chunks +252 lines, -161 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/doc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/gkvlite_utils.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/gkvlite_utils_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/globalinfo.go View 2 chunks +8 lines, -18 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/internal/goon/goon.go View 1 chunk +104 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/internal/goon/goon.infra_testing View 0 chunks +-1 lines, --1 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/key.go View 1 chunk +236 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/key_test.go View 1 chunk +51 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/memcache.go View 1 chunk +196 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/memcache_test.go View 6 chunks +65 lines, -63 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/memory.infra_testing View 1 chunk +4 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/plist.go View 1 chunk +637 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/memory/plist_test.go View 1 chunk +481 lines, -0 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/taskqueue.go View 14 chunks +97 lines, -80 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/taskqueue_data.go View 14 chunks +41 lines, -46 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/taskqueue_test.go View 20 chunks +67 lines, -66 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/memory/testing_utils_test.go View 3 chunks +41 lines, -34 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/taskqueue.go View 4 chunks +11 lines, -10 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/taskqueue_testable.go View 1 chunk +9 lines, -5 lines 0 comments Download
A + go/src/infra/gae/libs/wrapper/testable.go View 1 chunk +1 line, -1 line 0 comments Download
A go/src/infra/gae/libs/wrapper/unsafe/doc.go View 1 chunk +8 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/unsafe/memcache.go View 1 chunk +58 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/unsafe/memcache_test.go View 1 chunk +24 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/unsafe/unsafe.infra_testing View 1 chunk +4 lines, -0 lines 0 comments Download
A go/src/infra/gae/libs/wrapper/wrapper.infra_testing View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
iannucci
5 years, 5 months ago (2015-07-14 01:49:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230303003/1
5 years, 5 months ago (2015-07-14 01:50:38 UTC) #3
Vadim Sh.
The assumption was that "go test" covers all code that needs to be build :)
5 years, 5 months ago (2015-07-14 01:51:08 UTC) #4
Vadim Sh.
lgtm
5 years, 5 months ago (2015-07-14 01:51:14 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 01:54:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/92cee4406d23752a67bc01a2043f1...

Powered by Google App Engine
This is Rietveld 408576698