Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 12303030: Merge 182576 to M26 beta branch. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1410/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
===================================================================
--- chrome/browser/ui/views/extensions/extension_install_dialog_view.cc (revision 183257)
+++ chrome/browser/ui/views/extensions/extension_install_dialog_view.cc (working copy)
@@ -95,6 +95,7 @@
private:
// views::DialogDelegateView:
+ virtual int GetDialogButtons() const OVERRIDE;
virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
virtual int GetDefaultDialogButton() const OVERRIDE;
virtual bool Cancel() OVERRIDE;
@@ -443,6 +444,14 @@
GetWidget()->SetSize(GetWidget()->non_client_view()->GetPreferredSize());
}
+int ExtensionInstallDialogView::GetDialogButtons() const {
+ int buttons = prompt_.GetDialogButtons();
+ // Simply having just an OK button is *not* supported. See comment on function
+ // GetDialogButtons in dialog_delegate.h for reasons.
+ DCHECK_GT(buttons & ui::DIALOG_BUTTON_CANCEL, 0);
+ return buttons;
+}
+
string16 ExtensionInstallDialogView::GetDialogButtonLabel(
ui::DialogButton button) const {
switch (button) {

Powered by Google App Engine
This is Rietveld 408576698