More comments to StringBuffers.

More comments to StringBuffers.

Committed: https://code.google.com/p/dart/source/detail?r=18837

[sra1, 2013-02-19 21:08:45]

lgtm

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_sink.dart
File sdk/lib/core/string_sink.dart (right):

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_sink.d...
sdk/lib/core/string_sink.dart:11: * [:this:].
Consider using backtick, which is lighter on the eyes:

  * Converts [obj] to a String by invoking `toString` and adds the result to
  * `this`.

[Lasse Reichstein Nielsen, 2013-02-20 09:30:43]

lgtm

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_sink.dart
File sdk/lib/core/string_sink.dart (right):

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_sink.d...
sdk/lib/core/string_sink.dart:11: * [:this:].
Backtick is not part of the dartdoc spec (in the language spec), but [:...:] is.
That's probably just a case of dartdoc being violently underspecified, but until
it is I prefer using the parts that are there.

[Lasse Reichstein Nielsen, 2013-02-20 09:32:16]

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_buffer...
File sdk/lib/core/string_buffer.dart (right):

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_buffer...
sdk/lib/core/string_buffer.dart:18: /// This operation is in O(1).
It uses /** below and /// here. Please use /** for consistency.
Change "is in O(1)" to "is a constant time operation". It's too technical. Ditto
below.

[sra1, 2013-02-21 02:05:15]

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_sink.dart
File sdk/lib/core/string_sink.dart (right):

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_sink.d...
sdk/lib/core/string_sink.dart:11: * [:this:].
On 2013/02/20 09:30:43, Lasse Reichstein Nielsen wrote:
> Backtick is not part of the dartdoc spec (in the language spec), but [:...:]
is.
> That's probably just a case of dartdoc being violently underspecified, but
until
> it is I prefer using the parts that are there.

The spec currently says (copy & paste from
http://www.dartlang.org/docs/spec/latest/dart-language-specification.pdf ):

A token of the form [:code:] or `code` will render code as code in the formatted
output.

[floitsch, 2013-02-21 13:49:03]

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_buffer...
File sdk/lib/core/string_buffer.dart (right):

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_buffer...
sdk/lib/core/string_buffer.dart:18: /// This operation is in O(1).
On 2013/02/20 09:32:16, Lasse Reichstein Nielsen wrote:
> It uses /** below and /// here. Please use /** for consistency.
> Change "is in O(1)" to "is a constant time operation". It's too technical.
Ditto
> below.

Done.

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_sink.dart
File sdk/lib/core/string_sink.dart (right):

https://codereview.chromium.org/12303026/diff/2001/sdk/lib/core/string_sink.d...
sdk/lib/core/string_sink.dart:11: * [:this:].
On 2013/02/21 02:05:15, sra1 wrote:
> On 2013/02/20 09:30:43, Lasse Reichstein Nielsen wrote:
> > Backtick is not part of the dartdoc spec (in the language spec), but [:...:]
> is.
> > That's probably just a case of dartdoc being violently underspecified, but
> until
> > it is I prefer using the parts that are there.
> 
> The spec currently says (copy & paste from
> http://www.dartlang.org/docs/spec/latest/dart-language-specification.pdf ):
> 
> A token of the form [:code:] or `code` will render code as code in the
formatted
> output.

Done.