Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 12303009: Update grokdump to reflect current heap layout. (Closed)

Created:
7 years, 10 months ago by Michael Starzinger
Modified:
7 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev, dcarney
Visibility:
Public.

Description

Update grokdump to reflect current heap layout. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -100 lines) Patch
M tools/grokdump.py View 3 chunks +109 lines, -100 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
It takes some time before one figures out that the tool is broken instead of ...
7 years, 10 months ago (2013-02-18 18:10:03 UTC) #1
Yang
On 2013/02/18 18:10:03, Michael Starzinger wrote: > It takes some time before one figures out ...
7 years, 10 months ago (2013-02-19 08:41:46 UTC) #2
Yang
7 years, 10 months ago (2013-02-19 08:41:56 UTC) #3
On 2013/02/18 18:10:03, Michael Starzinger wrote:
> It takes some time before one figures out that the tool is broken instead of
the
> minidump being "weird". :)

LGTM, but I haven't verified the numbers.

Powered by Google App Engine
This is Rietveld 408576698