Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: sky/sdk/lib/widgets/toggleable.dart

Issue 1230273004: Make performance and position private since they don’t sync (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky; 5 import 'dart:sky' as sky;
6 6
7 import '../animation/animation_performance.dart'; 7 import '../animation/animation_performance.dart';
8 import '../animation/curves.dart'; 8 import '../animation/curves.dart';
9 import 'animated_component.dart'; 9 import 'animated_component.dart';
10 import 'basic.dart'; 10 import 'basic.dart';
11 11
12 typedef void ValueChanged(value); 12 typedef void ValueChanged(value);
13 13
14 const Duration _kCheckDuration = const Duration(milliseconds: 200); 14 const Duration _kCheckDuration = const Duration(milliseconds: 200);
15 15
16 abstract class Toggleable extends AnimatedComponent { 16 abstract class Toggleable extends AnimatedComponent {
17 17
18 Toggleable({ 18 Toggleable({
19 String key, 19 String key,
20 this.value, 20 this.value,
21 this.onChanged 21 this.onChanged
22 }) : super(key: key) { 22 }) : super(key: key) {
23 position = new AnimatedType<double>(0.0, end: 1.0); 23 _position = new AnimatedType<double>(0.0, end: 1.0);
24 performance = new AnimationPerformance() 24 _performance = new AnimationPerformance()
25 ..variable = position 25 ..variable = position
26 ..duration = _kCheckDuration 26 ..duration = _kCheckDuration
27 ..progress = value ? 1.0 : 0.0; 27 ..progress = value ? 1.0 : 0.0;
28 watchPerformance(performance); 28 watchPerformance(performance);
29 } 29 }
30 30
31 bool value; 31 bool value;
32 ValueChanged onChanged; 32 ValueChanged onChanged;
33 33
34 AnimatedType<double> position; 34 AnimatedType<double> _position;
35 AnimationPerformance performance; 35 AnimatedType<double> get position => _position;
36
37 AnimationPerformance _performance;
38 AnimationPerformance get performance => _performance;
36 39
37 void syncFields(Toggleable source) { 40 void syncFields(Toggleable source) {
38 onChanged = source.onChanged; 41 onChanged = source.onChanged;
39 if (value != source.value) { 42 if (value != source.value) {
40 value = source.value; 43 value = source.value;
41 // TODO(abarth): Setting the curve on the position means there's a 44 // TODO(abarth): Setting the curve on the position means there's a
42 // discontinuity when we reverse the timeline. 45 // discontinuity when we reverse the timeline.
43 if (value) { 46 if (value) {
44 position.curve = curveUp; 47 position.curve = curveUp;
45 performance.play(); 48 performance.play();
(...skipping 27 matching lines...) Expand all
73 height: size.height, 76 height: size.height,
74 child: new CustomPaint( 77 child: new CustomPaint(
75 token: position.value, 78 token: position.value,
76 callback: customPaintCallback 79 callback: customPaintCallback
77 ) 80 )
78 ), 81 ),
79 onGestureTap: _handleClick 82 onGestureTap: _handleClick
80 ); 83 );
81 } 84 }
82 } 85 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698