Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(85)

Issue 123025: Merge 17919 - We don't handle certificate errors during SSL renegotiation.... (Closed)

Created:
9 years, 8 months ago by laforge
Modified:
7 years, 8 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge 17919 - We don't handle certificate errors during SSL renegotiation. In the common case, the server sends the same certificate during renegotiation. Since the certificate has been verified, we can assume the certificate is good or has been accepted by the user. If the server sends a different certificate that has an error, we need to return an error code that won't trigger our certificate error handling code, which doesn't handle this case correctly. Add the ERR_CERT_ERROR_IN_SSL_RENEGOTIATION error for this purpose. R=rvargas BUG=http://crbug.com/13226 TEST=See http://crbug.com/13226 comment 9 Review URL: http://codereview.chromium.org/118410 TBR=wtc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
MM net/base/net_error_list.h View 1 chunk +7 lines, -0 lines 0 comments Download
MM net/base/ssl_client_socket_win.h View 1 chunk +1 line, -0 lines 0 comments Download
MM net/base/ssl_client_socket_win.cc View 3 chunks +28 lines, -8 lines 0 comments Download
MM net/http/http_network_transaction.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
9 years, 8 months ago (2009-06-11 17:27:00 UTC) #1
wtc
9 years, 8 months ago (2009-06-11 18:45:30 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698