ui/app_list/search/history.cc - Issue 1230243005: Move JoinString to the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/search/history.cc

Issue 1230243005: Move JoinString to the base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/app_list/search/history.cc

diff --git a/ui/app_list/search/history.cc b/ui/app_list/search/history.cc

index 6c540246ff7b220f0b554406d77502a7b91eba59..7d38bb269a07761bdc3c481ec5b29990ec816b60 100644

--- a/ui/app_list/search/history.cc

+++ b/ui/app_list/search/history.cc

@@ -17,7 +17,8 @@ namespace {

// Normalize the given string by joining all its tokens with a space.

std::string NormalizeString(const std::string& utf8) {

TokenizedString tokenized(base::UTF8ToUTF16(utf8));

- return base::UTF16ToUTF8(JoinString(tokenized.tokens(), ' '));

+ return base::UTF16ToUTF8(

+ base::JoinString(tokenized.tokens(), base::ASCIIToUTF16(" ")));

}

} // namespace