Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 123023002: Remove "solo window" feature (Closed)

Created:
6 years, 11 months ago by pkotwicz
Modified:
6 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tfarina, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Sebastien Gabriel
Visibility:
Public.

Description

The new design of the window headers does not use a super transparent window header when there is just one window on screen. The solo window feature is also broken in the M32 and M33 branches (crbug.com/330212) BUG=297187 TEST=None R=jamescook TBR=oshima (For trivial change in chrome/browser/chromeos/login/login_display_host_impl.*) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243500

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -913 lines) Patch
M ash/ash.gyp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M ash/root_window_controller.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ash/root_window_controller.cc View 1 3 chunks +0 lines, -12 lines 0 comments Download
M ash/wm/custom_frame_view_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/header_painter.h View 5 chunks +0 lines, -20 lines 0 comments Download
M ash/wm/header_painter.cc View 11 chunks +3 lines, -52 lines 0 comments Download
M ash/wm/header_painter_unittest.cc View 1 2 2 chunks +0 lines, -90 lines 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ash/wm/solo_window_tracker.h View 1 chunk +0 lines, -81 lines 0 comments Download
D ash/wm/solo_window_tracker.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D ash/wm/solo_window_tracker_unittest.cc View 1 chunk +0 lines, -429 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
James, can you please take a look? The designers have a new window header style ...
6 years, 11 months ago (2014-01-01 02:51:57 UTC) #1
James Cook
LGTM. I talked to sgabriel - he's OK with removing the solo window transparency. I ...
6 years, 11 months ago (2014-01-06 17:44:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/123023002/230001
6 years, 11 months ago (2014-01-07 18:46:35 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=65620
6 years, 11 months ago (2014-01-07 21:15:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/123023002/510001
6 years, 11 months ago (2014-01-08 01:31:37 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 06:26:25 UTC) #6
Message was sent while issue was closed.
Change committed as 243500

Powered by Google App Engine
This is Rietveld 408576698