content/browser/service_worker/service_worker_browsertest.cc - Issue 1230213004: [Background Sync] Sent sync registration details to worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 1230213004: [Background Sync] Sent sync registration details to worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bgsync-event-mek

Patch Set: Remove const ref from mojo StructPtr (with rebase) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_registration.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index e0e1fd44afd1a82dcec6d72a57dded6b16aaffcd..a9b172e7e524b7f46a5a93634539291b45d5b22e 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -171,6 +171,12 @@ void ExpectResultAndRun(bool expected,

continuation.Run();

}

+SyncRegistrationPtr CreateOneShotSyncRegistration(const std::string& tag) {

+ SyncRegistrationPtr registration = SyncRegistration::New();

+ registration->tag = tag;

+ return registration.Pass();

class WorkerActivatedObserver

: public ServiceWorkerContextObserver,

public base::RefCountedThreadSafe<WorkerActivatedObserver> {

@@ -789,6 +795,7 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {

ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));

version_->SetStatus(ServiceWorkerVersion::ACTIVATED);

version_->DispatchSyncEvent(

+ CreateOneShotSyncRegistration(""),

CreateReceiver(BrowserThread::UI, done, result));

}