content/browser/service_worker/service_worker_version.h - Issue 1230213004: [Background Sync] Sent sync registration details to worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1230213004: [Background Sync] Sent sync registration details to worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bgsync-event-mek

Patch Set: Use constref rather than pointer for FireOneShotSync Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/background_sync/background_sync_registration.h ('K') | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | content/renderer/background_sync/background_sync_client_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index e9f258f143b2f289795dc5474817767149267bf2..9177a0c4c078c6ced66d470937ad64c8b2381e5e 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -207,7 +207,8 @@ class CONTENT_EXPORT ServiceWorkerVersion

// notify completion.

// This must be called when the status() is ACTIVATED.

- void DispatchSyncEvent(const StatusCallback& callback);

+ void DispatchSyncEvent(SyncRegistrationPtr registration,

+ const StatusCallback& callback);

// Sends notificationclick event to the associated embedded worker and

// asynchronously calls |callback| when it errors out or it gets a response