content/browser/background_sync/background_sync_manager_unittest.cc - Issue 1230213004: [Background Sync] Sent sync registration details to worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager_unittest.cc

Issue 1230213004: [Background Sync] Sent sync registration details to worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bgsync-event-mek

Patch Set: Use constref rather than pointer for FireOneShotSync Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_manager.cc ('k') | content/browser/background_sync/background_sync_registration.h » ('j') | content/browser/background_sync/background_sync_registration.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager_unittest.cc

diff --git a/content/browser/background_sync/background_sync_manager_unittest.cc b/content/browser/background_sync/background_sync_manager_unittest.cc

index f0378ecfd3766be1506954a2f7b44f74cf39f22f..6728ae4db029f5ab130a4cda996b6602ba424695 100644

--- a/content/browser/background_sync/background_sync_manager_unittest.cc

+++ b/content/browser/background_sync/background_sync_manager_unittest.cc

@@ -183,10 +183,12 @@ class TestBackgroundSyncManager : public BackgroundSyncManager {

}

void FireOneShotSync(

+ const BackgroundSyncRegistration& registration,

const scoped_refptr<ServiceWorkerVersion>& active_version,

const ServiceWorkerVersion::StatusCallback& callback) override {

if (one_shot_callback_.is_null()) {

- BackgroundSyncManager::FireOneShotSync(active_version, callback);

+ BackgroundSyncManager::FireOneShotSync(registration, active_version,

+ callback);

} else {

one_shot_callback_.Run(active_version, callback);

}