Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Unified Diff: chrome/browser/autofill/autofill_external_delegate_browsertest.cc

Issue 12302034: Always Close the Autofill UI through the same path (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove old (now incorrect) test Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_external_delegate_browsertest.cc
diff --git a/chrome/browser/autofill/autofill_external_delegate_browsertest.cc b/chrome/browser/autofill/autofill_external_delegate_browsertest.cc
index 0c2863a4cf54d235836cd5693e5d36f51d6dbe0a..a2f894d4888a55ea4b7ad60b7a5a6ea7f7a95a58 100644
--- a/chrome/browser/autofill/autofill_external_delegate_browsertest.cc
+++ b/chrome/browser/autofill/autofill_external_delegate_browsertest.cc
@@ -84,14 +84,6 @@ class AutofillExternalDelegateBrowserTest
new MockAutofillExternalDelegate(web_contents_));
}
- // Normally the WebContents will automatically delete the delegate, but here
- // the delegate is owned by this test, so we have to manually destroy.
- virtual void WebContentsDestroyed(content::WebContents* web_contents)
- OVERRIDE {
- DCHECK_EQ(web_contents_, web_contents);
- autofill_external_delegate_.reset();
- }
-
protected:
content::WebContents* web_contents_;
scoped_ptr<MockAutofillExternalDelegate> autofill_external_delegate_;
@@ -131,14 +123,3 @@ IN_PROC_BROWSER_TEST_F(AutofillExternalDelegateBrowserTest,
EXPECT_TRUE(autofill_external_delegate_->popup_hidden());
}
-
-// Tests that closing the widget does not leak any resources. This test is
-// only really meaningful when run on the memory bots.
-IN_PROC_BROWSER_TEST_F(AutofillExternalDelegateBrowserTest,
- CloseWidgetAndNoLeaking) {
- autofill::GenerateTestAutofillPopup(autofill_external_delegate_.get());
-
- // Delete the view from under the delegate to ensure that the
- // delegate and the controller can handle the popup getting deleted elsewhere.
- autofill_external_delegate_->GetController()->view()->Hide();
-}

Powered by Google App Engine
This is Rietveld 408576698