chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc - Issue 12302034: Always Close the Autofill UI through the same path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

Issue 12302034: Always Close the Autofill UI through the same path (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix Test Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

index 4bd1f01de5cce9c78e1784b8805f2b1fa9980a67..bd945d8b898dd60a7b5e06b763fe207d6dec6870 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

@@ -332,7 +332,8 @@ TEST_F(AutofillPopupControllerUnitTest, GetOrCreate) {

static_cast<AutofillPopupController*>(controller3)->element_bounds());

controller3->Hide();

- delete test_controller;

+ // Hide the test_controller to delete it.

+ test_controller->DoHide();

}

#if !defined(OS_ANDROID)