chrome/browser/ui/android/autofill/autofill_popup_view_android.cc - Issue 12302034: Always Close the Autofill UI through the same path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 12302034: Always Close the Autofill UI through the same path (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix Test Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

index 69b2a4c31e4ef92c59de963200f96d256388c780..c74b64c208a61b310ff7a75b2d80414834185862 100644

--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

@@ -19,9 +19,7 @@ AutofillPopupViewAndroid::AutofillPopupViewAndroid(

AutofillPopupController* controller)

: controller_(controller) {}

-AutofillPopupViewAndroid::~AutofillPopupViewAndroid() {

- controller_->ViewDestroyed();

+AutofillPopupViewAndroid::~AutofillPopupViewAndroid() {}

void AutofillPopupViewAndroid::Show() {

JNIEnv* env = base::android::AttachCurrentThread();