Always Close the Autofill UI through the same path

chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/logging.h"
@@ skipping 154 matching lines @@
   } else {
     UpdateBoundsAndRedrawPopup();
   }
 
   delegate_->OnPopupShown(this);
 }
 
 void AutofillPopupControllerImpl::Hide() {
   if (is_hiding_)
     return;
   is_hiding_ = true;

[Ilya Sherman, 2013/02/26 01:02:32]

Since deletion now happens synchronously within this metod, is the |is_hiding_|
variable still needed?

[csharp, 2013/02/26 18:33:31]

True, fixed.

 
   SetSelectedLine(kNoSelection);
 
   delegate_->OnPopupHidden(this);
 
   if (view_)
     view_->Hide();
-  else
-    delete this;
+
+  delete this;
 }
 
 bool AutofillPopupControllerImpl::HandleKeyPressEvent(
     const content::NativeWebKeyboardEvent& event) {
   switch (event.windowsKeyCode) {
     case ui::VKEY_UP:
       SelectPreviousLine();
       return true;
     case ui::VKEY_DOWN:
       SelectNextLine();
@@ skipping 10 matching lines @@
     case ui::VKEY_DELETE:
       return (event.modifiers & content::NativeWebKeyboardEvent::ShiftKey) &&
              RemoveSelectedLine();
     case ui::VKEY_RETURN:
       return AcceptSelectedLine();
     default:
       return false;
   }
 }
 
-void AutofillPopupControllerImpl::ViewDestroyed() {
-  delete this;
-}
-
 void AutofillPopupControllerImpl::UpdateBoundsAndRedrawPopup() {
 #if !defined(OS_ANDROID)
   // TODO(csharp): Since UpdatePopupBounds can change the position of the popup,
   // the popup could end up jumping from above the element to below it.
   // It is unclear if it is better to keep the popup where it was, or if it
   // should try and move to its desired position.
   UpdatePopupBounds();
 #endif
 
   view_->UpdateBoundsAndRedrawPopup();
@@ skipping 425 matching lines @@
   if (bottom_available >= popup_required_height ||
       bottom_available >= top_available) {
     // The popup can appear below the field.
     return std::make_pair(bottom_growth_start, popup_required_height);
   } else {
     // The popup must appear above the field.
     return std::make_pair(top_growth_end - popup_required_height,
                           popup_required_height);
   }
 }