gpu/command_buffer/client/cmd_buffer_helper.cc - Issue 1230203007: Re-land: cc: Use worker context for one-copy tile initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/cmd_buffer_helper.cc

Issue 1230203007: Re-land: cc: Use worker context for one-copy tile initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/client/cmd_buffer_helper.cc

diff --git a/gpu/command_buffer/client/cmd_buffer_helper.cc b/gpu/command_buffer/client/cmd_buffer_helper.cc

index b6306d7fd935d7950404ba0f63ad636de413b2dd..2750903b716ab1bb648dcad7e7787ebecd583cfd 100644

--- a/gpu/command_buffer/client/cmd_buffer_helper.cc

+++ b/gpu/command_buffer/client/cmd_buffer_helper.cc

@@ -198,7 +198,8 @@ bool CommandBufferHelper::Finish() {

if (put_ == get_offset()) {

return true;

}

- DCHECK(HaveRingBuffer());

+ DCHECK(HaveRingBuffer() ||

+ error::IsError(command_buffer_->GetLastState().error));

Flush();

if (!WaitForGetOffsetInRange(put_, put_))

return false;

« no previous file with comments | « gpu/command_buffer/build_gles2_cmd_buffer.py ('k') | gpu/command_buffer/service/query_manager.cc » ('j') | no next file with comments »