Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5173)

Unified Diff: cc/raster/gpu_tile_task_worker_pool.cc

Issue 1230203007: Re-land: cc: Use worker context for one-copy tile initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and add missing locks Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/raster/gpu_tile_task_worker_pool.cc
diff --git a/cc/raster/gpu_tile_task_worker_pool.cc b/cc/raster/gpu_tile_task_worker_pool.cc
index aac2bd37fabc0f235a84f4199c85fcfbfc631cc9..c070390e2c4e3fd1ab7b9a7b3d65ee24e1aa912a 100644
--- a/cc/raster/gpu_tile_task_worker_pool.cc
+++ b/cc/raster/gpu_tile_task_worker_pool.cc
@@ -43,13 +43,9 @@ class RasterBufferImpl : public RasterBuffer {
ContextProvider* context_provider = rasterizer_->resource_provider()
->output_surface()
->worker_context_provider();
+ DCHECK(context_provider);
- // The context lock must be held while accessing the context on a
- // worker thread.
- base::AutoLock context_lock(*context_provider->GetLock());
-
- // Allow this worker thread to bind to context_provider.
- context_provider->DetachFromThread();
+ ContextProvider::ScopedContextLock scoped_context(context_provider);
gfx::Rect playback_rect = raster_full_rect;
if (resource_has_previous_content_) {
@@ -64,10 +60,7 @@ class RasterBufferImpl : public RasterBuffer {
playback_rect, scale);
// Barrier to sync worker context output to cc context.
- context_provider->ContextGL()->OrderingBarrierCHROMIUM();
-
- // Allow compositor thread to bind to context_provider.
- context_provider->DetachFromThread();
+ scoped_context.ContextGL()->OrderingBarrierCHROMIUM();
}
private:

Powered by Google App Engine
This is Rietveld 408576698