Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1230203003: Don't cache MemoryInfo instance on ConsoleMemory object. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
haraken, yurys
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't cache MemoryInfo instance on ConsoleMemory object. Round out r197581 and do same on console.memory R=yurys,haraken BUG=501270 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198785

Patch Set 1 #

Patch Set 2 : update corresponding console.memory layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M LayoutTests/inspector/console/console-memory-equals-console-memory.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-memory-equals-console-memory-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/ConsoleMemory.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/timing/ConsoleMemory.cpp View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sof
please take a look.
5 years, 5 months ago (2015-07-13 12:05:22 UTC) #2
yurys
lgtm
5 years, 5 months ago (2015-07-13 12:20:58 UTC) #3
haraken
LGTM
5 years, 5 months ago (2015-07-13 12:26:55 UTC) #4
sof
An inspector/console test had to be overturned - ptaal?
5 years, 5 months ago (2015-07-13 13:43:19 UTC) #5
yurys
On 2015/07/13 13:43:19, sof wrote: > An inspector/console test had to be overturned - ptaal? ...
5 years, 5 months ago (2015-07-13 13:58:51 UTC) #6
sof
On 2015/07/13 13:58:51, yurys wrote: > On 2015/07/13 13:43:19, sof wrote: > > An inspector/console ...
5 years, 5 months ago (2015-07-13 14:04:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230203003/20001
5 years, 5 months ago (2015-07-13 14:25:47 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:17:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198785

Powered by Google App Engine
This is Rietveld 408576698