Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 12302029: Linux: add a tool and code to make use_system_ffmpeg option more compatible (Closed)

Created:
7 years, 10 months ago by Paweł Hajdan Jr.
Modified:
7 years, 10 months ago
Reviewers:
Paweł, Ami GONE FROM CHROMIUM
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Linux: add a tool and code to make use_system_ffmpeg option more compatible This introduces a compile-time detection of ffmpeg configuration (which codecs are available). See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/fm5Oe_AC3Sc/qkbmC7txaSkJ for more context. No functional change for Google Chrome. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183463

Patch Set 1 #

Total comments: 2

Patch Set 2 : build/common.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 5 chunks +10 lines, -0 lines 0 comments Download
M media/media.gyp View 1 1 chunk +12 lines, -0 lines 0 comments Download
A tools/compile_test/compile_test.py View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 68 (0 generated)
Paweł Hajdan Jr.
7 years, 10 months ago (2013-02-19 17:39:14 UTC) #1
Ami GONE FROM CHROMIUM
IMO you're fighting a losing battle here, but I'm willing to let this in and ...
7 years, 10 months ago (2013-02-19 18:41:29 UTC) #2
Paweł Hajdan Jr.
Committed patchset #2 manually as r183463 (presubmit successful).
7 years, 10 months ago (2013-02-20 10:35:21 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/12302029/diff/1/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/12302029/diff/1/media/media.gyp#newcode474 media/media.gyp:474: '<!(python <(DEPTH)/tools/compile_test/compile_test.py ' On 2013/02/19 18:41:29, Ami Fischman wrote: ...
7 years, 10 months ago (2013-02-20 10:55:39 UTC) #4
Ami GONE FROM CHROMIUM
BTW do you have a deadline in mind for these ifdefs? Is it whenever FFmpeg ...
7 years, 10 months ago (2013-02-20 15:05:41 UTC) #5
Paweł
On Wed, Feb 20, 2013 at 4:05 PM, Ami Fischman <fischman@chromium.org> wrote: > BTW do ...
7 years, 10 months ago (2013-02-25 19:37:06 UTC) #6
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 19:49:14 UTC) #7
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 19:51:15 UTC) #8
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 19:56:58 UTC) #9
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 20:02:11 UTC) #10
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 20:15:34 UTC) #11
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 20:33:07 UTC) #12
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 20:46:08 UTC) #13
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 21:14:53 UTC) #14
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 21:35:40 UTC) #15
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 22:05:56 UTC) #16
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 22:31:00 UTC) #17
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 23:07:14 UTC) #18
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-25 23:40:20 UTC) #19
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 00:36:37 UTC) #20
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 01:06:24 UTC) #21
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 01:56:16 UTC) #22
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 02:47:59 UTC) #23
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 03:49:01 UTC) #24
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 05:00:01 UTC) #25
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 06:02:12 UTC) #26
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 06:50:11 UTC) #27
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 07:50:01 UTC) #28
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 09:03:43 UTC) #29
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 10:30:31 UTC) #30
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 11:46:06 UTC) #31
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 13:24:42 UTC) #32
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 14:41:15 UTC) #33
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 16:17:50 UTC) #34
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 17:19:07 UTC) #35
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 19:14:48 UTC) #36
Ami GONE FROM CHROMIUM
On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org > wrote: > ...
7 years, 10 months ago (2013-02-26 20:51:07 UTC) #37
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 18:18:47 UTC) #38
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 18:20:21 UTC) #39
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 18:26:13 UTC) #40
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 18:31:42 UTC) #41
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 18:44:11 UTC) #42
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 18:57:51 UTC) #43
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 19:15:38 UTC) #44
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 19:39:38 UTC) #45
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 20:06:56 UTC) #46
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 20:36:14 UTC) #47
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 21:01:00 UTC) #48
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 21:48:17 UTC) #49
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 22:26:27 UTC) #50
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 23:01:25 UTC) #51
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-04 23:39:44 UTC) #52
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 00:38:40 UTC) #53
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 01:37:39 UTC) #54
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 02:24:25 UTC) #55
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 03:26:43 UTC) #56
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 04:09:07 UTC) #57
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 05:37:21 UTC) #58
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 06:28:27 UTC) #59
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 07:42:27 UTC) #60
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 08:57:28 UTC) #61
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 10:01:38 UTC) #62
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 11:28:18 UTC) #63
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 13:09:58 UTC) #64
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 14:54:49 UTC) #65
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 16:06:28 UTC) #66
Paweł
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote: > On Mon, Feb ...
7 years, 9 months ago (2013-03-05 17:50:20 UTC) #67
Paweł
7 years, 9 months ago (2013-03-05 19:12:42 UTC) #68
On Mon, Feb 25, 2013 at 11:49 AM, Ami Fischman <fischman@chromium.org>wrote:

> On Mon, Feb 25, 2013 at 11:36 AM, Paweł Hajdan, Jr. <
> phajdan.jr@chromium.org> wrote:
>
>> On Wed, Feb 20, 2013 at 4:05 PM, Ami Fischman <fischman@chromium.org>wrote:
>>
>>> BTW do you have a deadline in mind for these ifdefs?
>>>
>> No, but I'm open to possible ideas.
>>
>
> 1 month from an ffmpeg release that includes a particular feature?
>

Sounds too short. Distros don't move so fast.

>  Is it whenever FFmpeg makes their next release which gentoo updates to?
>>>
>> It's more about the oldest FFmpeg/libav still in Gentoo portage that
>> needs the #ifdefs. Fortunately Gentoo is one of the faster distros to
>> update to new package versions.
>>
>
> How old the oldest version in portage right now?
>

Oldest ffmpeg version is 0.10.3, and oldest libav version is 0.8.4.


> libav released 9.2 yesterday, FFmpeg 1.1.3 was released 2 days ago, and
> FFmpeg 1.0.4 was released 18 days ago, so now is a particularly good time
> to eval gentoo's update speed :)
>

Note that latest available libav in Gentoo is indeed 9.3 as of today, and
ffmpeg 1.1.3 and 1.0.5 respectively. However, they are not pushed to stable
yet, because not every dependent package compiles with these new versions.

>  What about other distros?
>>>
>> Open question. For now I'm not aware of other distros compiling with
>> use_system_ffmpeg - even in Gentoo this is still a bit experimental.
>>
>
> My point was that we need to have a decision on how accomodating we want
> this facility to be.
> Perhaps the right answer is that each invocation of compile_test.py should
> have a TODO/bug tracking when it can be removed.  E.g. if the last ffmpeg
> release out right now was 2.4.5 and the feature being tested is on trunk,
> then it's reasonable to say TODO: remove when ffmpeg < 2.5 is out of
> portage (since ffmpeg is branched using major.minor).  libav seems to have
> moved to branching by major only.
> Is it easy to tell what the earliest version of ffmpeg&libav in portage is
> at a given time?
>

Yes, it's super easy. I think we could have such TODOs - note that the
latest versions can't support libav anyway, only ffmpeg. It seems the API
differences between the two are growing.

Paweł

Powered by Google App Engine
This is Rietveld 408576698