Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 12302015: Merge 182702 (Closed)

Created:
7 years, 10 months ago by Andrew T Wilson (Slow)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Merge 182702 > Add a modal confirmation dialog to the enterprise profile sign-in flow. > > When signing in with an enterprise user account, the user is prompted to > create a new Chrome profile, continue signing in with the current > profile, or cancel the signin process. > > BUG=171236 > TBR=jhawkins > > Review URL: https://codereview.chromium.org/12221111 TBR=atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/resources/profile_signin_confirmation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/profile_signin_confirmation.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/signin/signin_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.cc View 3 chunks +18 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A + chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/signin/profile_signin_confirmation_ui.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/signin/profile_signin_confirmation_ui.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Andrew T Wilson (Slow)
7 years, 10 months ago (2013-02-19 08:37:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698