Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1230183002: Change and simplify RelocInfo format. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change and simplify RelocInfo format. - we now have 6 bits to store RelocInfo mode. - removed a redundant tag byte per long reloc info entry. - renamed methods to be more precise. Committed: https://crrev.com/9d9256cc795135d3603acc97940e8876e8816c45 Cr-Commit-Position: refs/heads/master@{#29573}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -256 lines) Patch
M src/assembler.h View 1 6 chunks +32 lines, -41 lines 0 comments Download
M src/assembler.cc View 1 2 14 chunks +125 lines, -215 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Yang
Please take a look. The motivation for this change is so that we can add ...
5 years, 5 months ago (2015-07-10 10:12:00 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc File src/assembler.cc (left): https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc#oldcode287 src/assembler.cc:287: // pc-jump (variable length): Should we preserve the ...
5 years, 5 months ago (2015-07-10 11:22:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230183002/20001
5 years, 5 months ago (2015-07-10 11:42:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2190)
5 years, 5 months ago (2015-07-10 12:00:51 UTC) #8
Yang
fix typo
5 years, 5 months ago (2015-07-10 12:49:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230183002/40001
5 years, 5 months ago (2015-07-10 12:49:35 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-10 13:14:41 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 13:14:59 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d9256cc795135d3603acc97940e8876e8816c45
Cr-Commit-Position: refs/heads/master@{#29573}

Powered by Google App Engine
This is Rietveld 408576698