Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1230173002: Fixes the parser-shell by adding a dependency to StartupDataUtil. (Closed)

Created:
5 years, 5 months ago by epertoso
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixes the parser-shell by adding a dependency to StartupDataUtil. Committed: https://crrev.com/3c7d5820b11d6e8f6593fa627f359671eeb0b220 Cr-Commit-Position: refs/heads/master@{#29566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/parser-shell.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/parser-shell.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
epertoso
5 years, 5 months ago (2015-07-10 09:59:05 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-10 10:00:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230173002/1
5 years, 5 months ago (2015-07-10 10:01:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 10:26:57 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 10:27:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c7d5820b11d6e8f6593fa627f359671eeb0b220
Cr-Commit-Position: refs/heads/master@{#29566}

Powered by Google App Engine
This is Rietveld 408576698