ui/views/controls/menu/menu_item_view.h - Issue 1230163004: Selects last item in a menu when pressing 'up' initially

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_item_view.h

Issue 1230163004: Selects last item in a menu when pressing 'up' initially (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Selects last item in a menu when pressing 'up' initially (comments) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/controls/menu/menu_controller_unittest.cc ('K') | « ui/views/controls/menu/menu_controller_unittest.cc ('k') | ui/views/controls/menu/menu_item_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/menu/menu_item_view.h

diff --git a/ui/views/controls/menu/menu_item_view.h b/ui/views/controls/menu/menu_item_view.h

index 95d1491909e3a8add240042c60a31a5979721158..0db5f37c3620236ec85e606ec3a461df7b9c7f40 100644

--- a/ui/views/controls/menu/menu_item_view.h

+++ b/ui/views/controls/menu/menu_item_view.h

@@ -205,8 +205,7 @@ class VIEWS_EXPORT MenuItemView : public View {

Type type,

ui::MenuSeparatorType separator_style);

- // Returns the view that contains child menu items. If the submenu has

- // not been creates, this creates it.

+ // Creates and returns the view that contains child menu items.

virtual SubmenuView* CreateSubmenu();

// Returns true if this menu item has a submenu.