ui/views/controls/menu/menu_controller.h - Issue 1230163004: Selects last item in a menu when pressing 'up' initially

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller.h

Issue 1230163004: Selects last item in a menu when pressing 'up' initially (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Selects last item in a menu when pressing 'up' initially (comments) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_controller.h

diff --git a/ui/views/controls/menu/menu_controller.h b/ui/views/controls/menu/menu_controller.h

index e9354293e922245a2234b553e5aab5baebafe917..577d624786afeedba0ab0729e8ded6b7142c1bd3 100644

--- a/ui/views/controls/menu/menu_controller.h

+++ b/ui/views/controls/menu/menu_controller.h

@@ -435,9 +435,9 @@ class VIEWS_EXPORT MenuController : public WidgetObserver {

// Selects the next/previous menu item.

void IncrementSelection(int delta);

- // Returns the first selectable child menu item of |parent|. If there are no

- // selectable menu items NULL is returned.

- MenuItemView* FindFirstSelectableMenuItem(MenuItemView* parent);

+ // Returns the first (|delta| == 1) or the last (|delta| == -1) selectable

+ // child menu item of |parent|. If there are no selectable items returns NULL.

+ MenuItemView* FindInitialSelectableMenuItem(MenuItemView* parent, int delta);

// Returns the next selectable child menu item of |parent| starting at |index|

// and incrementing index by |delta|. If there are no more selectable menu

« no previous file with comments | « no previous file | ui/views/controls/menu/menu_controller.cc » ('j') | ui/views/controls/menu/menu_controller.cc » ('J')