Selects last item in a menu when pressing 'up' initially

ui/views/controls/menu/menu_controller.cc

Index: ui/views/controls/menu/menu_controller.cc
diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc
index 54d3410bdd8508a9c8e34d20036bacfa330a401f..60007081adbb776d149b79c53556616110269aef 100644
--- a/ui/views/controls/menu/menu_controller.cc
+++ b/ui/views/controls/menu/menu_controller.cc
@@ -1907,7 +1907,10 @@ void MenuController::IncrementSelection(int delta) {
       MenuItemView* to_select = FindFirstSelectableMenuItem(item);

[sadrul, 2015/07/14 04:17:41]

Hm. Perhaps we could add delta to FindFirstSelectableMenuItem() too, and pass
that from here? That way, we don't have to special case delta==1 here.

FindFirstSelectableMenuItem() is essentially equivalent to
FindNextSelectableMenuItem(index=-1, delta=1), right? Would it be possible to
cleanly merge the two into one?

[varkha, 2015/07/14 16:22:54]

Done.

       if (to_select)
         SetSelection(to_select, SELECTION_DEFAULT);
-      return;
+      if (delta == 1 || !to_select)
+        return;
+      // When decrementing fall through to select a previous item.
+      item = to_select;
     }
   }