ui/views/controls/menu/submenu_view.h - Issue 1230163004: Selects last item in a menu when pressing 'up' initially

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/submenu_view.h

Issue 1230163004: Selects last item in a menu when pressing 'up' initially (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Selects last item in a menu when pressing 'up' initially (nits) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/submenu_view.h

diff --git a/ui/views/controls/menu/submenu_view.h b/ui/views/controls/menu/submenu_view.h

index be221cf68967b876bbe9f164fe83604fcfccc953..5b7efb0ad8bcf4ea18172264de446f1b868ab5cc 100644

--- a/ui/views/controls/menu/submenu_view.h

+++ b/ui/views/controls/menu/submenu_view.h

@@ -90,7 +90,7 @@ class VIEWS_EXPORT SubmenuView : public PrefixDelegate,

base::string16 GetTextForRow(int row) override;

// Returns true if the menu is showing.

- bool IsShowing();

+ virtual bool IsShowing();

// Shows the menu at the specified location. Coordinates are in screen

// coordinates. max_width gives the max width the view should be.

« no previous file with comments | « ui/views/controls/menu/menu_item_view.h ('k') | no next file » | no next file with comments »