Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1230163002: Disable the pending task if the memory reducer is torn down. (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable the pending task if the memory reducer is torn down. BUG=chromium:508584 LOG=NO Committed: https://crrev.com/a5616e5d4bd6e867f59c1f819b20c536f1e2432c Cr-Commit-Position: refs/heads/master@{#29565}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Address comment, replace "teared" with "torn" #

Patch Set 4 : more nullptr #

Patch Set 5 : Fix check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/memory-reducer.h View 1 2 3 3 chunks +7 lines, -3 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 2 3 4 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
ulan
PTAL
5 years, 5 months ago (2015-07-10 09:08:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc File src/heap/memory-reducer.cc (right): https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc#newcode183 src/heap/memory-reducer.cc:183: pending_task_ = NULL; nullptr here and everywhere
5 years, 5 months ago (2015-07-10 09:10:54 UTC) #3
ulan
Thanks, landing https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc File src/heap/memory-reducer.cc (right): https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc#newcode183 src/heap/memory-reducer.cc:183: pending_task_ = NULL; On 2015/07/10 09:10:54, jochen ...
5 years, 5 months ago (2015-07-10 09:18:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230163002/60001
5 years, 5 months ago (2015-07-10 09:19:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/7579) (exceeded global retry quota)
5 years, 5 months ago (2015-07-10 09:21:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230163002/80001
5 years, 5 months ago (2015-07-10 09:25:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/5950) (exceeded global retry quota)
5 years, 5 months ago (2015-07-10 09:30:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230163002/80001
5 years, 5 months ago (2015-07-10 09:32:37 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-10 10:07:39 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 10:08:02 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a5616e5d4bd6e867f59c1f819b20c536f1e2432c
Cr-Commit-Position: refs/heads/master@{#29565}

Powered by Google App Engine
This is Rietveld 408576698