Make calls to AtomicString(const String&) explicit in inspector/

Make calls to AtomicString(const String&) explicit in inspector/

Make calls to AtomicString(const String&) explicit in inspector/.

This is one step towards making the AtomicString(const String&) constructor
explicit. This CL takes care only of the inspector/ part so that it is more
easily reviewable.

R=eseidel, vsevik@chromium.org
BUG=323739
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164411

[eseidel, 2013-12-31 23:11:34]

lgtm.

On Tue, Dec 31, 2013 at 1:36 PM,  <ch.dumez@samsung.com> wrote:
> Reviewers: eseidel, vsevik,
>
> Description:
> Make calls to AtomicString(const String&) explicit in inspector/
>
> Make calls to AtomicString(const String&) explicit in inspector/.
>
> This is one step towards making the AtomicString(const String&) constructor
> explicit. This CL takes care only of the inspector/ part so that it is more
> easily reviewable.
>
> R=eseidel, vsevik@chromium.org
> BUG=323739
>
> Please review this at https://codereview.chromium.org/123013002/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+8, -8 lines):
>   M Source/core/inspector/DOMEditor.cpp
>   M Source/core/inspector/InspectorDOMAgent.cpp
>   M Source/core/inspector/InspectorResourceAgent.cpp
>
>
> Index: Source/core/inspector/DOMEditor.cpp
> diff --git a/Source/core/inspector/DOMEditor.cpp
> b/Source/core/inspector/DOMEditor.cpp
> index
>
cd3a1f5981d4d2f0fee807eee466c83bfbdb9cb9..bb29cd98691322f10640d70f85d6f695abd7ae88
> 100644
> --- a/Source/core/inspector/DOMEditor.cpp
> +++ b/Source/core/inspector/DOMEditor.cpp
> @@ -370,12 +370,12 @@ bool DOMEditor::removeChild(Node* parentNode, Node*
> node, ExceptionState& except
>
>  bool DOMEditor::setAttribute(Element* element, const String& name, const
> String& value, ExceptionState& exceptionState)
>  {
> -    return m_history->perform(adoptPtr(new SetAttributeAction(element,
> name, value)), exceptionState);
> +    return m_history->perform(adoptPtr(new SetAttributeAction(element,
> AtomicString(name), AtomicString(value))), exceptionState);
>  }
>
>  bool DOMEditor::removeAttribute(Element* element, const String& name,
> ExceptionState& exceptionState)
>  {
> -    return m_history->perform(adoptPtr(new RemoveAttributeAction(element,
> name)), exceptionState);
> +    return m_history->perform(adoptPtr(new RemoveAttributeAction(element,
> AtomicString(name))), exceptionState);
>  }
>
>  bool DOMEditor::setOuterHTML(Node* node, const String& html, Node**
> newNode, ExceptionState& exceptionState)
> Index: Source/core/inspector/InspectorDOMAgent.cpp
> diff --git a/Source/core/inspector/InspectorDOMAgent.cpp
> b/Source/core/inspector/InspectorDOMAgent.cpp
> index
>
abb508d61d2b161c00be9a4df40fc35c6bc38a9c..6a3565cc284c8394a2d41b352058d9ab2e26320a
> 100644
> --- a/Source/core/inspector/InspectorDOMAgent.cpp
> +++ b/Source/core/inspector/InspectorDOMAgent.cpp
> @@ -562,7 +562,7 @@ void InspectorDOMAgent::querySelector(ErrorString*
> errorString, int nodeId, cons
>          return;
>
>      TrackExceptionState exceptionState;
> -    RefPtr<Element> element = node->querySelector(selectors,
> exceptionState);
> +    RefPtr<Element> element = node->querySelector(AtomicString(selectors),
> exceptionState);
>      if (exceptionState.hadException()) {
>          *errorString = "DOM Error while querying";
>          return;
> @@ -579,7 +579,7 @@ void InspectorDOMAgent::querySelectorAll(ErrorString*
> errorString, int nodeId, c
>          return;
>
>      TrackExceptionState exceptionState;
> -    RefPtr<NodeList> nodes = node->querySelectorAll(selectors,
> exceptionState);
> +    RefPtr<NodeList> nodes =
> node->querySelectorAll(AtomicString(selectors), exceptionState);
>      if (exceptionState.hadException()) {
>          *errorString = "DOM Error while querying";
>          return;
> @@ -762,7 +762,7 @@ void InspectorDOMAgent::setNodeName(ErrorString*
> errorString, int nodeId, const
>          return;
>
>      TrackExceptionState exceptionState;
> -    RefPtr<Element> newElem = oldNode->document().createElement(tagName,
> exceptionState);
> +    RefPtr<Element> newElem =
> oldNode->document().createElement(AtomicString(tagName), exceptionState);
>      if (exceptionState.hadException())
>          return;
>
> @@ -1018,7 +1018,7 @@ void InspectorDOMAgent::performSearch(ErrorString*,
> const String& whitespaceTrim
>          for (Vector<Document*>::iterator it = docs.begin(); it !=
> docs.end(); ++it) {
>              Document* document = *it;
>              TrackExceptionState exceptionState;
> -            RefPtr<NodeList> nodeList =
> document->querySelectorAll(whitespaceTrimmedQuery, exceptionState);
> +            RefPtr<NodeList> nodeList =
> document->querySelectorAll(AtomicString(whitespaceTrimmedQuery),
> exceptionState);
>              if (exceptionState.hadException() || !nodeList)
>                  continue;
>
> Index: Source/core/inspector/InspectorResourceAgent.cpp
> diff --git a/Source/core/inspector/InspectorResourceAgent.cpp
> b/Source/core/inspector/InspectorResourceAgent.cpp
> index
>
cb87d65f6ed727ccada011c5ca52b904518ff2a8..22c1167c7b046cec14a7bd8df0b9e6066b5290c2
> 100644
> --- a/Source/core/inspector/InspectorResourceAgent.cpp
> +++ b/Source/core/inspector/InspectorResourceAgent.cpp
> @@ -299,7 +299,7 @@ void InspectorResourceAgent::willSendRequest(unsigned
> long identifier, DocumentL
>          for (JSONObject::const_iterator it = headers->begin(); it != end;
> ++it) {
>              String value;
>              if (it->value->asString(&value))
> -                request.setHTTPHeaderField(it->key, value);
> +                request.setHTTPHeaderField(AtomicString(it->key),
> AtomicString(value));
>          }
>      }
>
> @@ -716,7 +716,7 @@ void
> InspectorResourceAgent::loadResourceForFrontend(ErrorString* errorString, c
>                  *errorString = "Request header \"" + it->key + "\" value is
> not a string";
>                  return;
>              }
> -            request.addHTTPHeaderField(it->key, value);
> +            request.addHTTPHeaderField(AtomicString(it->key),
> AtomicString(value));
>          }
>      }
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-01 16:02:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/123013002/1

[commit-bot: I haz the power, 2014-01-01 16:51:15]

Change committed as 164411