Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: net/http/partial_data.h

Issue 1230113012: [net] Better StopCaching() handling for HttpCache::Transaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing MockTransaction initializers Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/partial_data.h
diff --git a/net/http/partial_data.h b/net/http/partial_data.h
index 649d4623e0120bea74d6701567723d64b25bf1c6..c5ff01a89e5963332eae3d69f202397ca3151876 100644
--- a/net/http/partial_data.h
+++ b/net/http/partial_data.h
@@ -78,6 +78,17 @@ class PartialData {
// Sets the byte current range to start again at zero (for a truncated entry).
void SetRangeToStartDownload();
+ // Switch state to assume that the remainder of the response will be furnished
+ // via a network reqeust. Subsequent calls to
+ // ShouldValidateCache()/PrepareCacheValidation() will act as if the remainder
+ // of the response is not present in the cache and should be fetched over the
+ // network with validation.
+ //
+ // Returns true on success and false on failure. Fails only if the entire
+ // response has already been furnished and there is no need for any additional
+ // network reqeusts.
+ bool SkipCacheForRemainder();
+
// Returns true if the requested range is valid given the stored data.
bool IsRequestedRangeOK();
@@ -120,9 +131,6 @@ class PartialData {
bool initial_validation() const { return initial_validation_; }
private:
- // Returns the length to use when scanning the cache.
- int GetNextRangeLen();
-
// Completion routine for our callback.
void GetAvailableRangeCompleted(int64* start, int result);
@@ -130,7 +138,7 @@ class PartialData {
int64 current_range_end_;
int64 cached_start_;
int64 resource_size_;
- int cached_min_len_;
+ int64 cached_min_len_;
HttpByteRange byte_range_; // The range requested by the user.
// The clean set of extra headers (no ranges).
HttpRequestHeaders extra_headers_;

Powered by Google App Engine
This is Rietveld 408576698