Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_transaction.h

Issue 1230113012: [net] Better StopCaching() handling for HttpCache::Transaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing MockTransaction initializers Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_cache_transaction.cc ('K') | « net/http/http_cache_unittest.cc ('k') | net/http/http_transaction_test_util.h » ('j') | net/http/http_transaction_test_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_transaction.h
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h
index b4bc41519b0d0d97b422d63af5b5c82efcc0e11e..7c706dd9de52f80e4cf4690e9374fc9f8dcdc706 100644
--- a/net/http/http_transaction.h
+++ b/net/http/http_transaction.h
@@ -112,7 +112,10 @@ class NET_EXPORT_PRIVATE HttpTransaction {
virtual int Read(IOBuffer* buf, int buf_len,
const CompletionCallback& callback) = 0;
- // Stops further caching of this request by the HTTP cache, if there is any.
+ // Stops further caching of this request by the HTTP cache.
+ //
+ // Only valid if called after Start() and only when there are no pending
+ // operations.
virtual void StopCaching() = 0;
// Gets the full request headers sent to the server. This is guaranteed to
« net/http/http_cache_transaction.cc ('K') | « net/http/http_cache_unittest.cc ('k') | net/http/http_transaction_test_util.h » ('j') | net/http/http_transaction_test_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698