net/http/http_transaction.h - Issue 1230113012: [net] Better StopCaching() handling for HttpCache::Transaction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_transaction.h

Issue 1230113012: [net] Better StopCaching() handling for HttpCache::Transaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_transaction.h

diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h

index 6b8ea70cb3b679fd1ad1112923819a9869360cc7..dcb53db87189409a1254586c6e0caf330ec4e8b5 100644

--- a/net/http/http_transaction.h

+++ b/net/http/http_transaction.h

@@ -111,6 +111,7 @@ class NET_EXPORT_PRIVATE HttpTransaction {

const CompletionCallback& callback) = 0;

// Stops further caching of this request by the HTTP cache, if there is any.

+ // Should only be called when there are no pending operations.

virtual void StopCaching() = 0;

// Gets the full request headers sent to the server. This is guaranteed to

« net/http/http_cache_unittest.cc ('K') | « net/http/http_cache_unittest.cc ('k') | net/http/http_transaction_test_util.h » ('j') | net/http/http_transaction_test_util.cc » ('J')