[net] Better StopCaching() handling for HttpCache::Transaction.

net/http/disk_based_cert_cache_unittest.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/disk_based_cert_cache.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "net/base/completion_callback.h"
 #include "net/base/io_buffer.h"
@@ skipping 26 matching lines @@
 
 // MockTransactions are required to use the MockDiskCache backend.
 // |key| is a cache key, and is equivalent to the key that will be
 // used to store or retrieve certificates in the cache. |test_mode|
 // is an integer that is used to indicate properties of the test
 // transaction, mostly whether or not it is synchronous.
 // For testing the DiskBasedCertCache, other data members of the struct
 // are irrelevant. Only one MockTransaction per certificate can be used
 // at a time.
 MockTransaction CreateMockTransaction(const char* key, int test_mode) {
-  MockTransaction transaction = {key,  "", base::Time(), "", LOAD_NORMAL,
-                                 "",   "", base::Time(), "", test_mode,
-                                 NULL, 0,  OK};
+  MockTransaction transaction = {
+      key,          "", base::Time(), "",      LOAD_NORMAL, "", "",

[rvargas (doing something else), 2015/09/15 01:07:38]

This looks really bad. Can we use the same format of the const mocks and use one
line per member?

[asanka, 2015/09/17 21:59:40]

This is what 'git cl format' gives us :/

[rvargas (doing something else), 2015/09/19 01:09:34]

Really? If you manually set one per line, cl format will revert to _this_? If
that's the case do you mind filing a bug? (I don't think we have people fixing
these on the Chromium side (certainly there's no component or instructions), but
last time I said so, Sleevi said there was a team in charge)

+      base::Time(), "", test_mode,    nullptr, nullptr,     0,  OK};
 
   return transaction;
 }
 
 // Helper class, for use with DiskBasedCertCache::GetCertificate, that will
 // store the returned certificate handle and allow users to WaitForResult of
 // DiskBasedCertCache::GetCertificate.
 class TestGetCallback {
  public:
   TestGetCallback() : cert_handle_(NULL) {}
@@ skipping 466 matching lines @@
 
   cache.GetCertificate(kCert1.cache_key, get_callback2.callback());
   get_callback2.WaitForResult();
   EXPECT_TRUE(X509Certificate::IsSameOSCert(get_callback2.cert_handle(),
                                             cert->os_cert_handle()));
   EXPECT_EQ(1U, cache.mem_cache_hits_for_testing());
   ASSERT_NO_FATAL_FAILURE(CheckCertCached(&backend, kCert1));
 }
 
 }  // namespace net