[net] Better StopCaching() handling for HttpCache::Transaction.

net/http/partial_data.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_PARTIAL_DATA_H_
 #define NET_HTTP_PARTIAL_DATA_H_
 
 #include "base/basictypes.h"
 #include "base/memory/weak_ptr.h"
 #include "net/base/completion_callback.h"
@@ skipping 60 matching lines @@
 
   // Extracts info from headers already stored in the cache. Returns false if
   // there is any problem with the headers. |truncated| should be true if we
   // have an incomplete 200 entry.
   bool UpdateFromStoredHeaders(const HttpResponseHeaders* headers,
                                disk_cache::Entry* entry, bool truncated);
 
   // Sets the byte current range to start again at zero (for a truncated entry).
   void SetRangeToStartDownload();
 
+  // Switch to network reads for the remainder of the request.

[rvargas (doing something else), 2015/08/19 23:46:39]

Document what is the return value (the caller is assuming some specific behavior
here)

[asanka, 2015/09/04 19:09:04]

Done.

+  bool SkipCacheForRemainder();
+
   // Returns true if the requested range is valid given the stored data.
   bool IsRequestedRangeOK();
 
   // Returns true if the response headers match what we expect, false otherwise.
   bool ResponseHeadersOK(const HttpResponseHeaders* headers);
 
   // Fixes the response headers to include the right content length and range.
   // |success| is the result of the whole request so if it's false, we'll change
   // the result code to be 416.
   void FixResponseHeaders(HttpResponseHeaders* headers, bool success);
@@ skipping 23 matching lines @@
   void OnCacheReadCompleted(int result);
 
   // This method should be called after receiving data from the network, to
   // update the internal state about the current range.
   void OnNetworkReadCompleted(int result);
 
   bool initial_validation() const { return initial_validation_; }
 
  private:
   // Returns the length to use when scanning the cache.
-  int GetNextRangeLen();
+  int64 GetNextRangeLen();
 
   // Completion routine for our callback.
   void GetAvailableRangeCompleted(int64* start, int result);
 
   int64 current_range_start_;
   int64 current_range_end_;
   int64 cached_start_;
   int64 resource_size_;
-  int cached_min_len_;
+  int64 cached_min_len_;
   HttpByteRange byte_range_;  // The range requested by the user.
   // The clean set of extra headers (no ranges).
   HttpRequestHeaders extra_headers_;
   bool range_present_;  // True if next range entry is already stored.
   bool final_range_;
   bool sparse_entry_;
   bool truncated_;  // We have an incomplete 200 stored.
   bool initial_validation_;  // Only used for truncated entries.
   CompletionCallback callback_;
   base::WeakPtrFactory<PartialData> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PartialData);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_PARTIAL_DATA_H_