Issue 1230113006: Remove last use of Platform::networkService()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230113006: Remove last use of Platform::networkService() (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1, eseidel

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove last use of Platform::networkService() I forgot to remove the virtual function in Platform.h and missed two clients of this function. This CL switches those clients to keep their own network service. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a54fd877d45bae84fd558ba6b094939a9701daab

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -23 lines)			Patch
M	services/sky/document_view.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	services/sky/document_view.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	sky/engine/public/platform/Platform.h	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	sky/shell/shell.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/shell/ui/engine.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	3 chunks	+5 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 5 months ago (2015-07-14 16:41:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a54fd877d45bae84fd558ba6b094939a9701daab (presubmit successful).