Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1230103004: PPC: Switch CallConstructStub to take new.target in register. (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Switch CallConstructStub to take new.target in register. Port 1d9d895754e1d1cf824c11a9cce5e495fa47d5e2 Original commit message: This changes the calling convention of the CallConstructStub to take the original constructor (i.e. new.target in JS-speak) in a register instead of magically via the operand stack. For optimizing compilers the operand stack doesn't exist, hence cannot be peeked into. R=mstarzinger@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/a02f7e6f496976f960d37125ffeab3dc2983ce9a Cr-Commit-Position: refs/heads/master@{#29702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +13 lines, -8 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 5 months ago (2015-07-15 22:42:47 UTC) #1
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-07-16 07:34:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230103004/1
5 years, 5 months ago (2015-07-16 12:34:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 12:59:47 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a02f7e6f496976f960d37125ffeab3dc2983ce9a Cr-Commit-Position: refs/heads/master@{#29702}
5 years, 5 months ago (2015-07-16 13:00:01 UTC) #6
dstence
5 years, 5 months ago (2015-07-16 13:48:12 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698