Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 12301008: Merge 142745 (Closed)

Created:
7 years, 9 months ago by apavlov
Modified:
7 years, 9 months ago
Reviewers:
apavlov
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 142745 > Web Inspector: Fixed colorpicker editing and scrolling. > https://bugs.webkit.org/show_bug.cgi?id=109434. > > Patch by Vladislav Kaznacheev <kaznacheev@chromium.org>; on 2013-02-13 > Reviewed by Alexander Pavlov. > > The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of > SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183). > Added a special CSS class to mark the scroll target. > > No new tests. > > * inspector/front-end/SplitView.js: > (WebInspector.SplitView): > * inspector/front-end/StylesSidebarPane.js: > (WebInspector.StylePropertyTreeElement.prototype.updateTitle.): > * inspector/front-end/TabbedPane.js: > (WebInspector.TabbedPane): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M Source/WebCore/inspector/front-end/SplitView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/StylesSidebarPane.js View 3 chunks +8 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/front-end/TabbedPane.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
apavlov
7 years, 9 months ago (2013-02-18 10:32:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698