Issue 12301006: Merge 142887

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12301006: Merge 142887 (Closed)

Created:
7 years, 10 months ago by Tommy Widenflycht

Modified:
7 years, 10 months ago

Reviewers:
tommyw

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/

Visibility:
Public.

More Reviews

Description

Merge 142887 > MediaStream API: RTCDataChannel triggers a use-after-free > https://bugs.webkit.org/show_bug.cgi?id=109806 > > Reviewed by Adam Barth. > > Making sure RTCPeerConnection::stop() is always called at least once. > Also making sure that RTCDataChannels state gets set to Closed correctly. > > Hard to test in WebKit but covered by Chromium tests. > > * Modules/mediastream/RTCDataChannel.cpp: > (WebCore::RTCDataChannel::stop): > * Modules/mediastream/RTCPeerConnection.cpp: > (WebCore::RTCPeerConnection::~RTCPeerConnection): > (WebCore::RTCPeerConnection::stop): > TBR=tommyw@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143166

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	Source/WebCore/Modules/mediastream/RTCDataChannel.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages