Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 12301006: Merge 142887 (Closed)

Created:
7 years, 9 months ago by Tommy Widenflycht
Modified:
7 years, 9 months ago
Reviewers:
tommyw
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 142887 > MediaStream API: RTCDataChannel triggers a use-after-free > https://bugs.webkit.org/show_bug.cgi?id=109806 > > Reviewed by Adam Barth. > > Making sure RTCPeerConnection::stop() is always called at least once. > Also making sure that RTCDataChannels state gets set to Closed correctly. > > Hard to test in WebKit but covered by Chromium tests. > > * Modules/mediastream/RTCDataChannel.cpp: > (WebCore::RTCDataChannel::stop): > * Modules/mediastream/RTCPeerConnection.cpp: > (WebCore::RTCPeerConnection::~RTCPeerConnection): > (WebCore::RTCPeerConnection::stop): > TBR=tommyw@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/WebCore/Modules/mediastream/RTCDataChannel.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tommy Widenflycht
7 years, 9 months ago (2013-02-18 08:57:34 UTC) #1
Tommy Widenflycht
7 years, 9 months ago (2013-02-18 09:01:40 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698