Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: url/url_canon_icu.cc

Issue 1230093002: Get a descriptive error name from ICU Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_util_icu.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/url_canon_icu.cc
diff --git a/url/url_canon_icu.cc b/url/url_canon_icu.cc
index 8a80d7109d9cc925090ee247ef17253eb53136bb..4b9c2a334aea6178f38408d6398586452024bc26 100644
--- a/url/url_canon_icu.cc
+++ b/url/url_canon_icu.cc
@@ -12,6 +12,7 @@
#include "third_party/icu/source/common/unicode/ucnv.h"
#include "third_party/icu/source/common/unicode/ucnv_cb.h"
#include "third_party/icu/source/common/unicode/uidna.h"
+#include "third_party/icu/source/common/unicode/utypes.h"
#include "url/url_canon_icu.h"
#include "url/url_canon_internal.h" // for _itoa_s
@@ -100,7 +101,8 @@ struct UIDNAWrapper {
// registrars, search engines) converge toward a consensus.
value = uidna_openUTS46(UIDNA_CHECK_BIDI, &err);
if (U_FAILURE(err)) {
- CHECK(false) << "failed to open UTS46 data with error: " << err;
+ CHECK(false) << "failed to open UTS46 data with error: "
+ << u_errorName(err);
value = NULL;
}
}
« no previous file with comments | « net/base/net_util_icu.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698