Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1230073003: Revert: Move autofill tests chrome ChromeShellTest to ChromePublicTest (Closed)

Created:
5 years, 5 months ago by pkotwicz
Modified:
5 years, 5 months ago
Reviewers:
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert: Move autofill tests chrome ChromeShellTest to ChromePublicTest https://codereview.chromium.org/1225403006/ caused failure of AutofillDialogControllerTest TBR=pkotwicz NOTRY=true Committed: https://crrev.com/0dc61e9dd3f30f978beaa23685dbfa2a5f8d41a6 Cr-Commit-Position: refs/heads/master@{#339371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2064 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogResult.java View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 10 chunks +0 lines, -10 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 1 chunk +0 lines, -740 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 1 chunk +0 lines, -363 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java View 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/autofill/MockAutofillDialogController.java View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/autofill/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 1 chunk +0 lines, -277 lines 0 comments Download
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 6 chunks +12 lines, -19 lines 0 comments Download
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 5 chunks +6 lines, -15 lines 0 comments Download
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java View 6 chunks +7 lines, -17 lines 0 comments Download
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 2 chunks +7 lines, -14 lines 0 comments Download
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/MockAutofillDialogController.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230073003/1
5 years, 5 months ago (2015-07-18 01:16:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-18 01:20:45 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-18 01:21:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dc61e9dd3f30f978beaa23685dbfa2a5f8d41a6
Cr-Commit-Position: refs/heads/master@{#339371}

Powered by Google App Engine
This is Rietveld 408576698