Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 1230063011: [turbofan] Fix a -Wsign-compare error under GCC 4.9.2. (Closed)

Created:
5 years, 5 months ago by paul.l...
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix a -Wsign-compare error under GCC 4.9.2. Committed: https://crrev.com/5bc5ba1e16542da28b5c25ea847daea23bb5c12a Cr-Commit-Position: refs/heads/master@{#29632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/linkage-impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL.
5 years, 5 months ago (2015-07-14 00:59:07 UTC) #2
Benedikt Meurer
lgtm
5 years, 5 months ago (2015-07-14 02:49:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230063011/1
5 years, 5 months ago (2015-07-14 02:49:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 03:30:12 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 03:30:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bc5ba1e16542da28b5c25ea847daea23bb5c12a
Cr-Commit-Position: refs/heads/master@{#29632}

Powered by Google App Engine
This is Rietveld 408576698