tools/perf/benchmarks/octane.py - Issue 1230063007: Convert octane test score to float

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/octane.py

Issue 1230063007: Convert octane test score to float (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/octane.py

diff --git a/tools/perf/benchmarks/octane.py b/tools/perf/benchmarks/octane.py

index 74be2dc387b6c119fc9b8d6cc903fd22854cdec5..d27dc7c25061a7e98773760aff5487c32dcf5faa 100644

--- a/tools/perf/benchmarks/octane.py

+++ b/tools/perf/benchmarks/octane.py

@@ -116,7 +116,7 @@ class _OctaneMeasurement(page_test.PageTest):

'Unexpected result format "%s"' % score_and_name

if 'Skipped' not in score_and_name[1]:

name = score_and_name[0]

- score = int(score_and_name[1])

+ score = int(float(score_and_name[1]))

nednguyen 2015/07/23 14:59:01 why not just float(...)? I don't think we need to

results.AddValue(scalar.ScalarValue(

results.current_page, name, 'score', score, important=False,

description=DESCRIPTIONS.get(name)))

« no previous file with comments | « no previous file | no next file » | no next file with comments »