Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1230063007: Convert octane test score to float (Closed)

Created:
5 years, 5 months ago by alexanderk
Modified:
5 years, 4 months ago
Reviewers:
nednguyen, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert octane test score to float first to prevent fails on slow devices BUG=508907 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect Committed: https://crrev.com/3ac26e57adcdb0b08006a5f5f1e69e3615a28432 Cr-Commit-Position: refs/heads/master@{#342772}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Just use float instead of int #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/octane.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
alexanderk
5 years, 5 months ago (2015-07-10 12:38:24 UTC) #1
alexanderk
5 years, 5 months ago (2015-07-23 11:25:21 UTC) #3
nednguyen
https://codereview.chromium.org/1230063007/diff/1/tools/perf/benchmarks/octane.py File tools/perf/benchmarks/octane.py (right): https://codereview.chromium.org/1230063007/diff/1/tools/perf/benchmarks/octane.py#newcode119 tools/perf/benchmarks/octane.py:119: score = int(float(score_and_name[1])) why not just float(...)? I don't ...
5 years, 5 months ago (2015-07-23 14:59:01 UTC) #4
nednguyen
On 2015/07/23 14:59:01, nednguyen wrote: > https://codereview.chromium.org/1230063007/diff/1/tools/perf/benchmarks/octane.py > File tools/perf/benchmarks/octane.py (right): > > https://codereview.chromium.org/1230063007/diff/1/tools/perf/benchmarks/octane.py#newcode119 > ...
5 years, 5 months ago (2015-07-23 14:59:33 UTC) #5
alexanderk
On 2015/07/23 14:59:33, nednguyen wrote: > On 2015/07/23 14:59:01, nednguyen wrote: > > > https://codereview.chromium.org/1230063007/diff/1/tools/perf/benchmarks/octane.py ...
5 years, 5 months ago (2015-07-24 11:53:03 UTC) #6
nednguyen
On 2015/07/24 11:53:03, alexanderk wrote: > On 2015/07/23 14:59:33, nednguyen wrote: > > On 2015/07/23 ...
5 years, 5 months ago (2015-07-24 13:07:22 UTC) #7
dtu
lgtm Thanks for the fix!
5 years, 5 months ago (2015-07-24 20:06:17 UTC) #8
alexanderk
On 2015/07/24 20:06:17, dtu wrote: > lgtm > > Thanks for the fix! np
5 years, 4 months ago (2015-07-27 07:40:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230063007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1230063007/20001
5 years, 4 months ago (2015-08-10 23:25:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-11 01:27:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230063007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1230063007/20001
5 years, 4 months ago (2015-08-11 01:36:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 01:42:44 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 01:43:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ac26e57adcdb0b08006a5f5f1e69e3615a28432
Cr-Commit-Position: refs/heads/master@{#342772}

Powered by Google App Engine
This is Rietveld 408576698