OLD | NEW |
---|---|
1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "ios/web/net/cert_verifier_block_adapter.h" | 5 #include "ios/web/net/cert_verifier_block_adapter.h" |
6 | 6 |
7 #include "base/message_loop/message_loop.h" | |
7 #include "base/test/ios/wait_util.h" | 8 #include "base/test/ios/wait_util.h" |
9 #include "ios/web/public/test/test_web_thread_bundle.h" | |
8 #include "net/base/net_errors.h" | 10 #include "net/base/net_errors.h" |
11 #include "net/base/test_data_directory.h" | |
12 #include "net/cert/cert_verifier.h" | |
9 #include "net/cert/cert_verify_result.h" | 13 #include "net/cert/cert_verify_result.h" |
10 #include "net/cert/crl_set.h" | 14 #include "net/cert/crl_set.h" |
15 #include "net/cert/mock_cert_verifier.h" | |
11 #include "net/cert/x509_certificate.h" | 16 #include "net/cert/x509_certificate.h" |
12 #include "testing/gmock/include/gmock/gmock.h" | 17 #include "net/log/net_log.h" |
18 #include "net/test/cert_test_util.h" | |
13 #include "testing/platform_test.h" | 19 #include "testing/platform_test.h" |
14 | 20 |
15 namespace net { | 21 namespace net { |
16 | 22 |
17 using testing::_; | |
18 | |
19 namespace { | 23 namespace { |
20 | 24 // Test cert filename. |
25 const char kCertFileName[] = "ok_cert.pem"; | |
21 // Test hostname for CertVerifier. | 26 // Test hostname for CertVerifier. |
22 const char kHostName[] = "chromium.org"; | 27 const char kHostName[] = "www.example.com"; |
23 // Test OCSP response for CertVerifier. | |
24 const char kOcspResponse[] = "ocsp"; | |
25 | |
26 // Mocks CertVerifier for CertVerifierBlockAdapter testing. | |
27 class CertVerifierMock : public CertVerifier { | |
28 public: | |
29 MOCK_METHOD9(Verify, | |
30 int(X509Certificate* cert, | |
31 const std::string& hostname, | |
32 const std::string& ocsp_response, | |
33 int flags, | |
34 CRLSet* crl_set, | |
35 CertVerifyResult* verify_result, | |
36 const CompletionCallback& callback, | |
37 scoped_ptr<Request>* out_req, | |
38 const BoundNetLog& net_log)); | |
39 }; | |
40 | |
41 // Sets CertVerifyResult to emulate CertVerifier behavior. | |
42 ACTION_P(SetVerifyResult, result) { | |
43 *arg5 = result; | |
44 } | |
45 | |
46 // Calls CompletionCallback to emulate CertVerifier behavior. | |
47 ACTION(RunCallback) { | |
48 arg6.Run(0); | |
49 } | |
50 | 28 |
51 } // namespace | 29 } // namespace |
52 | 30 |
53 // Test fixture to test CertVerifierBlockAdapter class. | 31 // Test fixture to test CertVerifierBlockAdapter class. |
54 class CertVerifierBlockAdapterTest : public PlatformTest { | 32 class CertVerifierBlockAdapterTest : public PlatformTest { |
55 protected: | 33 protected: |
56 void SetUp() override { | 34 void SetUp() override { |
57 PlatformTest::SetUp(); | 35 PlatformTest::SetUp(); |
58 | 36 cert_ = ImportCertFromFile(GetTestCertsDirectory(), kCertFileName).Pass(); |
davidben
2015/08/19 18:51:45
I think the .Pass() isn't necessary here since it'
Eugene But (OOO till 7-30)
2015/08/20 01:14:41
Done.
| |
59 cert_ = new X509Certificate("test", "test", base::Time(), base::Time()); | 37 ASSERT_TRUE(cert_); |
60 scoped_ptr<CertVerifierMock> cert_verifier_mock(new CertVerifierMock()); | |
61 cert_verifier_mock_ = cert_verifier_mock.get(); | |
62 test_adapter_.reset( | |
63 new CertVerifierBlockAdapter(cert_verifier_mock.Pass())); | |
64 } | 38 } |
65 | 39 |
66 // Performs synchronous verification. | 40 // Performs synchronous verification. |
67 void Verify(CertVerifierBlockAdapter::Params params, | 41 void Verify(CertVerifierBlockAdapter* cert_verifier_adapter, |
68 scoped_ptr<net::CertVerifyResult>* result, | 42 CertVerifierBlockAdapter::Params params, |
69 int* status) { | 43 net::CertVerifyResult* cert_verify_result, |
44 int* status_result) { | |
70 __block bool verification_completed = false; | 45 __block bool verification_completed = false; |
71 test_adapter_->Verify(params, | 46 cert_verifier_adapter->Verify( |
72 ^(scoped_ptr<net::CertVerifyResult> callback_result, | 47 params, ^(net::CertVerifyResult callback_cert_verify_result, |
73 int callback_status) { | 48 int callback_status_result) { |
74 *result = callback_result.Pass(); | 49 *cert_verify_result = callback_cert_verify_result; |
75 *status = callback_status; | 50 *status_result = callback_status_result; |
76 verification_completed = true; | 51 verification_completed = true; |
77 }); | 52 }); |
78 base::test::ios::WaitUntilCondition(^{ | 53 base::test::ios::WaitUntilCondition(^{ |
79 return verification_completed; | 54 return verification_completed; |
80 }); | 55 }, base::MessageLoop::current(), base::TimeDelta()); |
81 } | 56 } |
82 | 57 |
83 // Fake certificate created for testing. | 58 web::TestWebThreadBundle thread_bundle_; |
84 scoped_refptr<X509Certificate> cert_; | 59 scoped_refptr<X509Certificate> cert_; |
85 // Testable |CertVerifierBlockAdapter| object. | 60 NetLog net_log_; |
86 scoped_ptr<CertVerifierBlockAdapter> test_adapter_; | |
87 // CertVerifier mock owned by |test_adapter_|. | |
88 CertVerifierMock* cert_verifier_mock_; | |
89 }; | 61 }; |
90 | 62 |
91 // Tests |Verify| with default params and synchronous verification. | 63 // Tests |Verify| with default params and synchronous verification. |
92 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndSync) { | 64 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndSync) { |
93 // Set up expectation. | 65 // Set up verifier mock. |
94 net::CertVerifyResult expectedResult; | 66 MockCertVerifier verifier; |
95 expectedResult.cert_status = net::CERT_STATUS_AUTHORITY_INVALID; | 67 CertVerifierBlockAdapter test_adapter(&verifier, &net_log_); |
96 const int kExpectedStatus = 0; | 68 const int kExpectedStatus = OK; |
davidben
2015/08/19 18:51:45
This doesn't make any sense. It should return ERR_
Eugene But (OOO till 7-30)
2015/08/20 01:14:41
Done.
| |
97 EXPECT_CALL(*cert_verifier_mock_, | 69 net::CertVerifyResult expected_cert_verify_result; |
davidben
2015/08/19 18:51:45
Nit: stray net:: prefix? Also elsewhere in the fil
Eugene But (OOO till 7-30)
2015/08/20 01:14:41
Done.
| |
98 Verify(cert_.get(), kHostName, "", 0, nullptr, _, _, _, _)) | 70 expected_cert_verify_result.cert_status = net::CERT_STATUS_AUTHORITY_INVALID; |
99 .Times(1) | 71 expected_cert_verify_result.verified_cert = cert_; |
100 .WillOnce(testing::DoAll(SetVerifyResult(expectedResult), | 72 verifier.AddResultForCertAndHost( |
101 testing::Return(kExpectedStatus))); | 73 cert_.get(), kHostName, expected_cert_verify_result, kExpectedStatus); |
102 | 74 |
103 // Call |Verify|. | 75 // Call |Verify|. |
104 scoped_ptr<CertVerifyResult> actualResult; | 76 CertVerifyResult actual_cert_verify_result; |
105 int actualStatus = -1; | 77 int actual_status = -1; |
106 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | 78 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); |
107 Verify(params, &actualResult, &actualStatus); | 79 Verify(&test_adapter, params, &actual_cert_verify_result, &actual_status); |
108 | 80 |
109 // Ensure that Verification results are correct. | 81 // Ensure that Verification results are correct. |
110 EXPECT_EQ(kExpectedStatus, actualStatus); | 82 EXPECT_EQ(kExpectedStatus, actual_status); |
111 EXPECT_EQ(expectedResult.cert_status, actualResult->cert_status); | 83 EXPECT_EQ(expected_cert_verify_result.cert_status, |
84 actual_cert_verify_result.cert_status); | |
112 } | 85 } |
113 | 86 |
114 // Tests |Verify| with default params and asynchronous verification. | 87 // Tests |Verify| with default params and asynchronous verification using real |
88 // net::CertVerifier and ok_cert.pem cert. | |
115 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndAsync) { | 89 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndAsync) { |
90 // Call |Verify|. | |
91 scoped_ptr<net::CertVerifier> verifier(net::CertVerifier::CreateDefault()); | |
92 CertVerifierBlockAdapter test_adapter(verifier.get(), &net_log_); | |
93 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | |
94 CertVerifyResult actual_cert_verify_result; | |
95 int actual_status = -1; | |
96 Verify(&test_adapter, params, &actual_cert_verify_result, &actual_status); | |
97 | |
98 // Ensure that Verification results are correct. | |
99 EXPECT_FALSE(actual_cert_verify_result.is_issued_by_known_root); | |
100 EXPECT_EQ(ERR_CERT_AUTHORITY_INVALID, actual_status); | |
101 } | |
102 | |
103 // Tests |Verify| with invalid cert argument. | |
104 TEST_F(CertVerifierBlockAdapterTest, InvalidCert) { | |
105 // Call |Verify|. | |
106 MockCertVerifier verifier; | |
107 CertVerifierBlockAdapter test_adapter(&verifier, &net_log_); | |
108 CertVerifyResult actual_cert_verify_result; | |
109 int actual_status = -1; | |
110 CertVerifierBlockAdapter::Params params(nullptr, kHostName); | |
111 Verify(&test_adapter, params, &actual_cert_verify_result, &actual_status); | |
112 | |
113 // Ensure that Verification results are correct. | |
114 EXPECT_EQ(ERR_INVALID_ARGUMENT, actual_status); | |
115 } | |
116 | |
117 // Tests |Verify| with invalid hostname argument. | |
118 TEST_F(CertVerifierBlockAdapterTest, InvalidHostname) { | |
119 // Call |Verify|. | |
120 MockCertVerifier verifier; | |
121 CertVerifierBlockAdapter test_adapter(&verifier, &net_log_); | |
122 CertVerifyResult actual_cert_verify_result; | |
123 int actual_status = -1; | |
124 CertVerifierBlockAdapter::Params params(cert_.get(), std::string()); | |
125 Verify(&test_adapter, params, &actual_cert_verify_result, &actual_status); | |
126 | |
127 // Ensure that Verification results are correct. | |
128 EXPECT_EQ(ERR_INVALID_ARGUMENT, actual_status); | |
129 } | |
130 | |
131 // Tests |Verify| with synchronous error. | |
132 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndSyncError) { | |
116 // Set up expectation. | 133 // Set up expectation. |
117 net::CertVerifyResult expectedResult; | 134 MockCertVerifier verifier; |
118 expectedResult.is_issued_by_known_root = true; | 135 CertVerifierBlockAdapter test_adapter(&verifier, &net_log_); |
119 const int kExpectedStatus = 0; | 136 const int kExpectedStatus = ERR_INSUFFICIENT_RESOURCES; |
120 EXPECT_CALL(*cert_verifier_mock_, | 137 net::CertVerifyResult expected_cert_verify_result; |
121 Verify(cert_.get(), kHostName, "", 0, nullptr, _, _, _, _)) | 138 expected_cert_verify_result.verified_cert = cert_; |
122 .Times(1) | 139 verifier.AddResultForCertAndHost( |
123 .WillOnce(testing::DoAll(SetVerifyResult(expectedResult), RunCallback(), | 140 cert_.get(), kHostName, expected_cert_verify_result, kExpectedStatus); |
124 testing::Return(ERR_IO_PENDING))); | |
125 | 141 |
126 // Call |Verify|. | 142 // Call |Verify|. |
127 scoped_ptr<CertVerifyResult> actualResult; | 143 CertVerifyResult actual_cert_verify_result; |
128 int actualStatus = -1; | 144 int actual_status = -1; |
129 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | 145 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); |
130 Verify(params, &actualResult, &actualStatus); | 146 Verify(&test_adapter, params, &actual_cert_verify_result, &actual_status); |
131 | 147 |
132 // Ensure that Verification results are correct. | 148 // Ensure that Verification results are correct. |
133 EXPECT_EQ(kExpectedStatus, actualStatus); | 149 EXPECT_EQ(kExpectedStatus, actual_status); |
134 EXPECT_EQ(expectedResult.is_issued_by_known_root, | |
135 actualResult->is_issued_by_known_root); | |
136 } | |
137 | |
138 // Tests |Verify| with invalid arguments. | |
139 TEST_F(CertVerifierBlockAdapterTest, InvalidParamsAndError) { | |
140 // Set up expectation. | |
141 const int kExpectedStatus = ERR_INVALID_ARGUMENT; | |
142 EXPECT_CALL(*cert_verifier_mock_, | |
143 Verify(nullptr, "", "", 0, nullptr, _, _, _, _)) | |
144 .Times(1) | |
145 .WillOnce(testing::Return(kExpectedStatus)); | |
146 | |
147 // Call |Verify|. | |
148 scoped_ptr<CertVerifyResult> actualResult; | |
149 int actualStatus = -1; | |
150 CertVerifierBlockAdapter::Params params(nullptr, ""); | |
151 Verify(params, &actualResult, &actualStatus); | |
152 | |
153 // Ensure that Verification results are correct. | |
154 EXPECT_EQ(kExpectedStatus, actualStatus); | |
155 EXPECT_FALSE(actualResult); | |
156 } | |
157 | |
158 // Tests |Verify| with error. | |
159 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndError) { | |
160 // Set up expectation. | |
161 const int kExpectedStatus = ERR_INSUFFICIENT_RESOURCES; | |
162 EXPECT_CALL(*cert_verifier_mock_, | |
163 Verify(cert_.get(), kHostName, "", 0, nullptr, _, _, _, _)) | |
164 .Times(1) | |
165 .WillOnce(testing::Return(kExpectedStatus)); | |
166 | |
167 // Call |Verify|. | |
168 scoped_ptr<CertVerifyResult> actualResult; | |
169 int actualStatus = -1; | |
170 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | |
171 Verify(params, &actualResult, &actualStatus); | |
172 | |
173 // Ensure that Verification results are correct. | |
174 EXPECT_EQ(kExpectedStatus, actualStatus); | |
175 EXPECT_FALSE(actualResult); | |
176 } | |
177 | |
178 // Tests |Verify| with all params and synchronous verification. | |
179 TEST_F(CertVerifierBlockAdapterTest, AllParamsAndSync) { | |
180 // Set up expectation. | |
181 net::CertVerifyResult expectedResult; | |
182 expectedResult.verified_cert = cert_; | |
183 const int kExpectedStatus = 0; | |
184 scoped_refptr<CRLSet> crl_set(CRLSet::EmptyCRLSetForTesting()); | |
185 EXPECT_CALL(*cert_verifier_mock_, | |
186 Verify(cert_.get(), kHostName, kOcspResponse, | |
187 CertVerifier::VERIFY_EV_CERT, crl_set.get(), _, _, _, _)) | |
188 .Times(1) | |
189 .WillOnce(testing::DoAll(SetVerifyResult(expectedResult), | |
190 testing::Return(kExpectedStatus))); | |
191 | |
192 // Call |Verify|. | |
193 scoped_ptr<CertVerifyResult> actualResult; | |
194 int actualStatus = -1; | |
195 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | |
196 params.ocsp_response = kOcspResponse; | |
197 params.flags = CertVerifier::VERIFY_EV_CERT; | |
198 params.crl_set = crl_set; | |
199 Verify(params, &actualResult, &actualStatus); | |
200 | |
201 // Ensure that Verification results are correct. | |
202 EXPECT_EQ(kExpectedStatus, actualStatus); | |
203 EXPECT_EQ(expectedResult.verified_cert, actualResult->verified_cert); | |
204 } | 150 } |
205 | 151 |
206 } // namespace | 152 } // namespace |
OLD | NEW |