OLD | NEW |
---|---|
1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "ios/web/net/cert_verifier_block_adapter.h" | 5 #include "ios/web/net/cert_verifier_block_adapter.h" |
6 | 6 |
7 #include "base/location.h" | |
8 #include "base/message_loop/message_loop.h" | |
Ryan Sleevi
2015/08/14 21:43:54
Blergh. It seems the iOS test code still uses the
Eugene But (OOO till 7-30)
2015/08/19 17:57:36
Acknowledged.
| |
7 #include "base/test/ios/wait_util.h" | 9 #include "base/test/ios/wait_util.h" |
10 #include "base/thread_task_runner_handle.h" | |
11 #include "ios/web/public/test/test_web_thread_bundle.h" | |
8 #include "net/base/net_errors.h" | 12 #include "net/base/net_errors.h" |
13 #include "net/base/test_data_directory.h" | |
14 #include "net/cert/cert_verifier.h" | |
9 #include "net/cert/cert_verify_result.h" | 15 #include "net/cert/cert_verify_result.h" |
10 #include "net/cert/crl_set.h" | 16 #include "net/cert/crl_set.h" |
11 #include "net/cert/x509_certificate.h" | 17 #include "net/cert/x509_certificate.h" |
18 #include "net/log/net_log.h" | |
19 #include "net/test/cert_test_util.h" | |
12 #include "testing/gmock/include/gmock/gmock.h" | 20 #include "testing/gmock/include/gmock/gmock.h" |
13 #include "testing/platform_test.h" | 21 #include "testing/platform_test.h" |
14 | 22 |
15 namespace net { | 23 namespace net { |
16 | 24 |
17 using testing::_; | 25 using testing::_; |
18 | 26 |
19 namespace { | 27 namespace { |
20 | 28 // Test cert filename. |
29 const char kCertFileName[] = "ok_cert.pem"; | |
21 // Test hostname for CertVerifier. | 30 // Test hostname for CertVerifier. |
22 const char kHostName[] = "chromium.org"; | 31 const char kHostName[] = "chromium.org"; |
23 // Test OCSP response for CertVerifier. | 32 // Test OCSP response for CertVerifier. |
24 const char kOcspResponse[] = "ocsp"; | 33 const char kOcspResponse[] = "ocsp"; |
25 | 34 |
26 // Mocks CertVerifier for CertVerifierBlockAdapter testing. | 35 // Mocks CertVerifier for CertVerifierBlockAdapter testing. |
27 class CertVerifierMock : public CertVerifier { | 36 class CertVerifierMock : public CertVerifier { |
28 public: | 37 public: |
29 MOCK_METHOD9(Verify, | 38 MOCK_METHOD9(Verify, |
30 int(X509Certificate* cert, | 39 int(X509Certificate* cert, |
31 const std::string& hostname, | 40 const std::string& hostname, |
32 const std::string& ocsp_response, | 41 const std::string& ocsp_response, |
33 int flags, | 42 int flags, |
34 CRLSet* crl_set, | 43 CRLSet* crl_set, |
35 CertVerifyResult* verify_result, | 44 CertVerifyResult* verify_result, |
36 const CompletionCallback& callback, | 45 const CompletionCallback& callback, |
37 scoped_ptr<Request>* out_req, | 46 scoped_ptr<Request>* out_req, |
38 const BoundNetLog& net_log)); | 47 const BoundNetLog& net_log)); |
39 }; | 48 }; |
40 | 49 |
41 // Sets CertVerifyResult to emulate CertVerifier behavior. | 50 // Sets CertVerifyResult to emulate CertVerifier behavior. |
42 ACTION_P(SetVerifyResult, result) { | 51 ACTION_P(SetVerifyResult, result) { |
43 *arg5 = result; | 52 *arg5 = result; |
44 } | 53 } |
45 | 54 |
46 // Calls CompletionCallback to emulate CertVerifier behavior. | 55 // Calls CompletionCallback to emulate CertVerifier behavior. |
47 ACTION(RunCallback) { | 56 ACTION_P(RunCallback, status_result) { |
48 arg6.Run(0); | 57 base::ThreadTaskRunnerHandle::Get()->PostTask( |
58 FROM_HERE, base::Bind(arg6, status_result)); | |
49 } | 59 } |
50 | 60 |
51 } // namespace | 61 } // namespace |
52 | 62 |
53 // Test fixture to test CertVerifierBlockAdapter class. | 63 // Test fixture to test CertVerifierBlockAdapter class. |
54 class CertVerifierBlockAdapterTest : public PlatformTest { | 64 class CertVerifierBlockAdapterTest : public PlatformTest { |
55 protected: | 65 protected: |
56 void SetUp() override { | 66 CertVerifierBlockAdapterTest() |
57 PlatformTest::SetUp(); | 67 : cert_(ImportCertFromFile(GetTestCertsDirectory(), kCertFileName)), |
58 | 68 test_adapter_( |
59 cert_ = new X509Certificate("test", "test", base::Time(), base::Time()); | 69 new CertVerifierBlockAdapter(&cert_verifier_mock_, &net_log_)) { |
60 scoped_ptr<CertVerifierMock> cert_verifier_mock(new CertVerifierMock()); | 70 DCHECK(cert_); |
61 cert_verifier_mock_ = cert_verifier_mock.get(); | |
62 test_adapter_.reset( | |
63 new CertVerifierBlockAdapter(cert_verifier_mock.Pass())); | |
64 } | 71 } |
65 | 72 |
66 // Performs synchronous verification. | 73 // Performs synchronous verification. |
67 void Verify(CertVerifierBlockAdapter::Params params, | 74 void Verify(CertVerifierBlockAdapter::Params params, |
68 scoped_ptr<net::CertVerifyResult>* result, | 75 net::CertVerifyResult* cert_verify_result, |
69 int* status) { | 76 int* status_result) { |
70 __block bool verification_completed = false; | 77 __block bool verification_completed = false; |
71 test_adapter_->Verify(params, | 78 test_adapter_->Verify(params, |
72 ^(scoped_ptr<net::CertVerifyResult> callback_result, | 79 ^(net::CertVerifyResult callback_cert_verify_result, |
73 int callback_status) { | 80 int callback_status_result) { |
74 *result = callback_result.Pass(); | 81 *cert_verify_result = callback_cert_verify_result; |
75 *status = callback_status; | 82 *status_result = callback_status_result; |
76 verification_completed = true; | 83 verification_completed = true; |
77 }); | 84 }); |
78 base::test::ios::WaitUntilCondition(^{ | 85 base::test::ios::WaitUntilCondition(^{ |
79 return verification_completed; | 86 return verification_completed; |
80 }); | 87 }, base::MessageLoop::current(), base::TimeDelta()); |
81 } | 88 } |
82 | 89 |
83 // Fake certificate created for testing. | 90 web::TestWebThreadBundle thread_bundle_; |
84 scoped_refptr<X509Certificate> cert_; | 91 scoped_refptr<X509Certificate> cert_; |
85 // Testable |CertVerifierBlockAdapter| object. | 92 CertVerifierMock cert_verifier_mock_; |
93 NetLog net_log_; | |
86 scoped_ptr<CertVerifierBlockAdapter> test_adapter_; | 94 scoped_ptr<CertVerifierBlockAdapter> test_adapter_; |
87 // CertVerifier mock owned by |test_adapter_|. | |
88 CertVerifierMock* cert_verifier_mock_; | |
89 }; | 95 }; |
90 | 96 |
91 // Tests |Verify| with default params and synchronous verification. | 97 // Tests |Verify| with default params and synchronous verification. |
92 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndSync) { | 98 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndSync) { |
93 // Set up expectation. | 99 // Set up expectation. |
94 net::CertVerifyResult expectedResult; | 100 net::CertVerifyResult expected_cert_verify_result; |
95 expectedResult.cert_status = net::CERT_STATUS_AUTHORITY_INVALID; | 101 expected_cert_verify_result.cert_status = net::CERT_STATUS_AUTHORITY_INVALID; |
96 const int kExpectedStatus = 0; | 102 const int kExpectedStatus = OK; |
97 EXPECT_CALL(*cert_verifier_mock_, | 103 EXPECT_CALL(cert_verifier_mock_, Verify(cert_.get(), kHostName, std::string(), |
98 Verify(cert_.get(), kHostName, "", 0, nullptr, _, _, _, _)) | 104 0, nullptr, _, _, _, _)) |
99 .Times(1) | 105 .Times(1) |
100 .WillOnce(testing::DoAll(SetVerifyResult(expectedResult), | 106 .WillOnce(testing::DoAll(SetVerifyResult(expected_cert_verify_result), |
101 testing::Return(kExpectedStatus))); | 107 testing::Return(kExpectedStatus))); |
102 | 108 |
103 // Call |Verify|. | 109 // Call |Verify|. |
104 scoped_ptr<CertVerifyResult> actualResult; | 110 CertVerifyResult actual_cert_verify_result; |
105 int actualStatus = -1; | 111 int actual_status = -1; |
106 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | 112 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); |
107 Verify(params, &actualResult, &actualStatus); | 113 Verify(params, &actual_cert_verify_result, &actual_status); |
108 | 114 |
109 // Ensure that Verification results are correct. | 115 // Ensure that Verification results are correct. |
110 EXPECT_EQ(kExpectedStatus, actualStatus); | 116 EXPECT_EQ(kExpectedStatus, actual_status); |
111 EXPECT_EQ(expectedResult.cert_status, actualResult->cert_status); | 117 EXPECT_EQ(expected_cert_verify_result.cert_status, |
118 actual_cert_verify_result.cert_status); | |
112 } | 119 } |
113 | 120 |
114 // Tests |Verify| with default params and asynchronous verification. | 121 // Tests |Verify| with default params and asynchronous verification. |
115 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndAsync) { | 122 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndAsync) { |
116 // Set up expectation. | 123 // Set up expectation. |
117 net::CertVerifyResult expectedResult; | 124 net::CertVerifyResult expected_cert_verify_result; |
118 expectedResult.is_issued_by_known_root = true; | 125 expected_cert_verify_result.is_issued_by_known_root = true; |
119 const int kExpectedStatus = 0; | 126 const int kExpectedStatus = OK; |
120 EXPECT_CALL(*cert_verifier_mock_, | 127 EXPECT_CALL(cert_verifier_mock_, Verify(cert_.get(), kHostName, std::string(), |
121 Verify(cert_.get(), kHostName, "", 0, nullptr, _, _, _, _)) | 128 0, nullptr, _, _, _, _)) |
122 .Times(1) | 129 .Times(1) |
123 .WillOnce(testing::DoAll(SetVerifyResult(expectedResult), RunCallback(), | 130 .WillOnce(testing::DoAll(SetVerifyResult(expected_cert_verify_result), |
131 RunCallback(kExpectedStatus), | |
124 testing::Return(ERR_IO_PENDING))); | 132 testing::Return(ERR_IO_PENDING))); |
125 | 133 |
126 // Call |Verify|. | 134 // Call |Verify|. |
127 scoped_ptr<CertVerifyResult> actualResult; | 135 CertVerifyResult actual_cert_verify_result; |
128 int actualStatus = -1; | 136 int actual_status = -1; |
129 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | 137 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); |
130 Verify(params, &actualResult, &actualStatus); | 138 Verify(params, &actual_cert_verify_result, &actual_status); |
131 | 139 |
132 // Ensure that Verification results are correct. | 140 // Ensure that Verification results are correct. |
133 EXPECT_EQ(kExpectedStatus, actualStatus); | 141 EXPECT_EQ(kExpectedStatus, actual_status); |
134 EXPECT_EQ(expectedResult.is_issued_by_known_root, | 142 EXPECT_EQ(expected_cert_verify_result.is_issued_by_known_root, |
135 actualResult->is_issued_by_known_root); | 143 actual_cert_verify_result.is_issued_by_known_root); |
136 } | 144 } |
137 | 145 |
138 // Tests |Verify| with invalid arguments. | 146 // Tests |Verify| with invalid cert argument. |
139 TEST_F(CertVerifierBlockAdapterTest, InvalidParamsAndError) { | 147 TEST_F(CertVerifierBlockAdapterTest, InvalidCert) { |
148 // Call |Verify|. | |
149 CertVerifyResult actual_cert_verify_result; | |
150 int actual_status = -1; | |
151 CertVerifierBlockAdapter::Params params(nullptr, kHostName); | |
152 Verify(params, &actual_cert_verify_result, &actual_status); | |
153 | |
154 // Ensure that Verification results are correct. | |
155 EXPECT_EQ(ERR_INVALID_ARGUMENT, actual_status); | |
156 } | |
157 | |
158 // Tests |Verify| with invalid hostname argument. | |
159 TEST_F(CertVerifierBlockAdapterTest, InvalidHostname) { | |
160 // Call |Verify|. | |
161 CertVerifyResult actual_cert_verify_result; | |
162 int actual_status = -1; | |
163 CertVerifierBlockAdapter::Params params(cert_.get(), std::string()); | |
164 Verify(params, &actual_cert_verify_result, &actual_status); | |
165 | |
166 // Ensure that Verification results are correct. | |
167 EXPECT_EQ(ERR_INVALID_ARGUMENT, actual_status); | |
168 } | |
169 | |
170 // Tests |Verify| with synchronous error. | |
171 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndSyncError) { | |
140 // Set up expectation. | 172 // Set up expectation. |
141 const int kExpectedStatus = ERR_INVALID_ARGUMENT; | 173 const int kExpectedStatus = ERR_INSUFFICIENT_RESOURCES; |
142 EXPECT_CALL(*cert_verifier_mock_, | 174 EXPECT_CALL(cert_verifier_mock_, Verify(cert_.get(), kHostName, std::string(), |
143 Verify(nullptr, "", "", 0, nullptr, _, _, _, _)) | 175 0, nullptr, _, _, _, _)) |
144 .Times(1) | 176 .Times(1) |
145 .WillOnce(testing::Return(kExpectedStatus)); | 177 .WillOnce(testing::Return(kExpectedStatus)); |
146 | 178 |
147 // Call |Verify|. | 179 // Call |Verify|. |
148 scoped_ptr<CertVerifyResult> actualResult; | 180 CertVerifyResult actual_cert_verify_result; |
149 int actualStatus = -1; | 181 int actual_status = -1; |
150 CertVerifierBlockAdapter::Params params(nullptr, ""); | 182 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); |
151 Verify(params, &actualResult, &actualStatus); | 183 Verify(params, &actual_cert_verify_result, &actual_status); |
152 | 184 |
153 // Ensure that Verification results are correct. | 185 // Ensure that Verification results are correct. |
154 EXPECT_EQ(kExpectedStatus, actualStatus); | 186 EXPECT_EQ(kExpectedStatus, actual_status); |
155 EXPECT_FALSE(actualResult); | |
156 } | 187 } |
157 | 188 |
158 // Tests |Verify| with error. | 189 // Tests |Verify| with asynchronous error. |
159 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndError) { | 190 TEST_F(CertVerifierBlockAdapterTest, DefaultParamsAndAsyncError) { |
160 // Set up expectation. | 191 // Set up expectation. |
161 const int kExpectedStatus = ERR_INSUFFICIENT_RESOURCES; | 192 net::CertVerifyResult expected_cert_verify_result; |
162 EXPECT_CALL(*cert_verifier_mock_, | 193 expected_cert_verify_result.is_issued_by_known_root = true; |
163 Verify(cert_.get(), kHostName, "", 0, nullptr, _, _, _, _)) | 194 const int kExpectedStatus = ERR_ACCESS_DENIED; |
195 EXPECT_CALL(cert_verifier_mock_, Verify(cert_.get(), kHostName, std::string(), | |
196 0, nullptr, _, _, _, _)) | |
164 .Times(1) | 197 .Times(1) |
165 .WillOnce(testing::Return(kExpectedStatus)); | 198 .WillOnce(testing::DoAll(SetVerifyResult(expected_cert_verify_result), |
199 RunCallback(kExpectedStatus), | |
200 testing::Return(ERR_IO_PENDING))); | |
166 | 201 |
167 // Call |Verify|. | 202 // Call |Verify|. |
168 scoped_ptr<CertVerifyResult> actualResult; | 203 CertVerifyResult actual_cert_verify_result; |
169 int actualStatus = -1; | 204 int actual_status = -1; |
170 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | 205 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); |
171 Verify(params, &actualResult, &actualStatus); | 206 Verify(params, &actual_cert_verify_result, &actual_status); |
172 | 207 |
173 // Ensure that Verification results are correct. | 208 // Ensure that Verification results are correct. |
174 EXPECT_EQ(kExpectedStatus, actualStatus); | 209 EXPECT_EQ(kExpectedStatus, actual_status); |
175 EXPECT_FALSE(actualResult); | 210 EXPECT_EQ(expected_cert_verify_result.is_issued_by_known_root, |
211 actual_cert_verify_result.is_issued_by_known_root); | |
176 } | 212 } |
177 | 213 |
178 // Tests |Verify| with all params and synchronous verification. | 214 // Tests |Verify| with all params and synchronous verification. |
179 TEST_F(CertVerifierBlockAdapterTest, AllParamsAndSync) { | 215 TEST_F(CertVerifierBlockAdapterTest, AllParamsAndSync) { |
180 // Set up expectation. | 216 // Set up expectation. |
181 net::CertVerifyResult expectedResult; | 217 net::CertVerifyResult expected_cert_verify_result; |
182 expectedResult.verified_cert = cert_; | 218 expected_cert_verify_result.verified_cert = cert_; |
183 const int kExpectedStatus = 0; | 219 const int kExpectedStatus = OK; |
184 scoped_refptr<CRLSet> crl_set(CRLSet::EmptyCRLSetForTesting()); | 220 scoped_refptr<CRLSet> crl_set(CRLSet::EmptyCRLSetForTesting()); |
185 EXPECT_CALL(*cert_verifier_mock_, | 221 EXPECT_CALL(cert_verifier_mock_, |
186 Verify(cert_.get(), kHostName, kOcspResponse, | 222 Verify(cert_.get(), kHostName, kOcspResponse, |
187 CertVerifier::VERIFY_EV_CERT, crl_set.get(), _, _, _, _)) | 223 CertVerifier::VERIFY_EV_CERT, crl_set.get(), _, _, _, _)) |
188 .Times(1) | 224 .Times(1) |
189 .WillOnce(testing::DoAll(SetVerifyResult(expectedResult), | 225 .WillOnce(testing::DoAll(SetVerifyResult(expected_cert_verify_result), |
190 testing::Return(kExpectedStatus))); | 226 testing::Return(kExpectedStatus))); |
191 | 227 |
192 // Call |Verify|. | 228 // Call |Verify|. |
193 scoped_ptr<CertVerifyResult> actualResult; | 229 CertVerifyResult actual_cert_verify_result; |
194 int actualStatus = -1; | 230 int actual_status = -1; |
195 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); | 231 CertVerifierBlockAdapter::Params params(cert_.get(), kHostName); |
196 params.ocsp_response = kOcspResponse; | 232 params.ocsp_response = kOcspResponse; |
197 params.flags = CertVerifier::VERIFY_EV_CERT; | 233 params.flags = CertVerifier::VERIFY_EV_CERT; |
198 params.crl_set = crl_set; | 234 params.crl_set = crl_set; |
199 Verify(params, &actualResult, &actualStatus); | 235 Verify(params, &actual_cert_verify_result, &actual_status); |
200 | 236 |
201 // Ensure that Verification results are correct. | 237 // Ensure that Verification results are correct. |
202 EXPECT_EQ(kExpectedStatus, actualStatus); | 238 EXPECT_EQ(kExpectedStatus, actual_status); |
203 EXPECT_EQ(expectedResult.verified_cert, actualResult->verified_cert); | 239 EXPECT_EQ(expected_cert_verify_result.verified_cert, |
240 actual_cert_verify_result.verified_cert); | |
204 } | 241 } |
205 | 242 |
206 } // namespace | 243 } // namespace |
OLD | NEW |