Issue 1230033002: [AutoLayout] Address further concerns raised in https://codereview.chromium.org/1230583003

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230033002: [AutoLayout] Address further concerns raised in https://codereview.chromium.org/1230583003 (Closed)

Created:
5 years, 5 months ago by Chinmay

Modified:
5 years, 5 months ago

Reviewers:
Hixie, abarth-chromium, eseidel

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

[AutoLayout] Address further concerns raised in https://codereview.chromium.org/1230583003 R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/094e7b6f45d1a7cb55eccc6cbc247a1ecf95d393

Patch Set 1 #

Total comments: 2

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
	M	sky/sdk/example/rendering/simple_autolayout.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
	M	sky/sdk/lib/rendering/auto_layout.dart	View		5 chunks	+19 lines, -13 lines	2 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hixie

lgtm https://codereview.chromium.org/1230033002/diff/1/sky/sdk/lib/rendering/auto_layout.dart File sky/sdk/lib/rendering/auto_layout.dart (right): https://codereview.chromium.org/1230033002/diff/1/sky/sdk/lib/rendering/auto_layout.dart#newcode58 sky/sdk/lib/rendering/auto_layout.dart:58: /// it other properties (if necessary) s/it/the/, I ...

5 years, 5 months ago (2015-07-09 21:52:07 UTC) #3

Chinmay

5 years, 5 months ago (2015-07-09 22:29:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
094e7b6f45d1a7cb55eccc6cbc247a1ecf95d393 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages