Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1230033002: [AutoLayout] Address further concerns raised in https://codereview.chromium.org/1230583003 (Closed)

Created:
5 years, 5 months ago by Chinmay
Modified:
5 years, 5 months ago
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M sky/sdk/example/rendering/simple_autolayout.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/sdk/lib/rendering/auto_layout.dart View 5 chunks +19 lines, -13 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
Chinmay
5 years, 5 months ago (2015-07-09 21:37:07 UTC) #2
Hixie
lgtm https://codereview.chromium.org/1230033002/diff/1/sky/sdk/lib/rendering/auto_layout.dart File sky/sdk/lib/rendering/auto_layout.dart (right): https://codereview.chromium.org/1230033002/diff/1/sky/sdk/lib/rendering/auto_layout.dart#newcode58 sky/sdk/lib/rendering/auto_layout.dart:58: /// it other properties (if necessary) s/it/the/, I ...
5 years, 5 months ago (2015-07-09 21:52:07 UTC) #3
Chinmay
5 years, 5 months ago (2015-07-09 22:29:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
094e7b6f45d1a7cb55eccc6cbc247a1ecf95d393 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698