plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java - Issue 12300043: Move setValue operation into a separate JsDeclarativeVariable interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

Issue 12300043: Move setValue operation into a separate JsDeclarativeVariable interface (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: fcr Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java ('k') | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsObjectBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

index 37fb95172062462bbd42245fd52c4dce7c55323f..2eee99d2bbcbce52eb90b3e1d96be6772a2816e5 100755

--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

@@ -168,7 +168,7 @@ public class CallFrameImpl implements CallFrame {

// This name should be string. We are making it string as a fall-back strategy.

String varNameStr = ref.getName().toString();

// 'this' variable is not mutable. Consider making it mutable.

- result = new JsVariableBase.Impl(null, valueLoader, mirror, varNameStr);

+ result = new JsVariableBase.Impl(valueLoader, mirror, varNameStr);

}

if (result != null) {

receiverVariableRef.compareAndSet(null, result);