Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java

Issue 12300043: Move setValue operation into a separate JsDeclarativeVariable interface (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: fcr Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java
index 341edcb799d39b216d831449c74101872f018f68..4fa4d190afbde531b6f69249bd624289cb2458ba 100755
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java
@@ -5,15 +5,10 @@
package org.chromium.sdk;
/**
- * An object that represents a variable in a browser JavaScript VM call frame.
+ * An object that represents a variable in a browser JavaScript VM, a call frame
+ * variable and/or an object property.
*/
public interface JsVariable {
-
- /**
- * @return whether it is possible to read this variable
- */
- boolean isReadable();
-
/**
* Returns the value of this variable.
*
@@ -36,46 +31,13 @@ public interface JsVariable {
String getName();
/**
- * @return whether it is possible to modify this variable
- */
- boolean isMutable();
-
- /**
- * Sets a new value for this variable.
- *
- * @param newValue to set
- * @param callback to report the operation result to
- * @param syncCallback to report the end of any processing
- * @see #isMutable()
- * @throws UnsupportedOperationException if this variable is not mutable
- */
- RelayOk setValue(JsValue newValue, SetValueCallback callback, SyncCallback syncCallback)
- throws UnsupportedOperationException;
-
- /**
- * A callback to use while setting a variable value.
- */
- interface SetValueCallback {
- /**
- * Variable is successfully updated. New value is available in {@link JsVariable#getValue()}.
- */
- void success();
-
- /**
- * Variable hasn't been updated because exception was thrown. Most probably this exception was
- * thrown from setter function.
- */
- void exceptionThrown(JsValue exception);
-
- /**
- * Variable hasn't been updated for unknown reason.
- */
- void failure(Exception cause);
- }
-
- /**
* Returns object property data if variable is an object property and its descriptor
* is available.
*/
JsObjectProperty asObjectProperty();
+
+ /**
+ * Casts this to declarative variable type if available or returns null.
+ */
+ JsDeclarativeVariable asDeclarativeVariable();
}

Powered by Google App Engine
This is Rietveld 408576698