test/cctest/test-assembler-x64.cc - Issue 12300018: Made Isolate a mandatory parameter for everything Handle-related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-assembler-x64.cc

Issue 12300018: Made Isolate a mandatory parameter for everything Handle-related. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Even less Isolate::Current Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-assembler-x64.cc

diff --git a/test/cctest/test-assembler-x64.cc b/test/cctest/test-assembler-x64.cc

index d81923fa5c227d3e174b602a8f6464fdfb82311a..78ef4fb2beba6ccd90a05fbab472750cebe9b096 100644

--- a/test/cctest/test-assembler-x64.cc

+++ b/test/cctest/test-assembler-x64.cc

@@ -376,7 +376,8 @@ TEST(AssemblerMultiByteNop) {

InitializeVM();

v8::HandleScope scope;

v8::internal::byte buffer[1024];

- Assembler assm(Isolate::Current(), buffer, sizeof(buffer));

+ Isolate* isolate = Isolate::Current();

+ Assembler assm(isolate, buffer, sizeof(buffer));

__ push(rbx);

__ push(rcx);

__ push(rdx);

@@ -425,11 +426,11 @@ TEST(AssemblerMultiByteNop) {

CodeDesc desc;

assm.GetCode(&desc);

- Code* code = Code::cast(HEAP->CreateCode(

+ Code* code = Code::cast(isolate->heap()->CreateCode(

desc,

Code::ComputeFlags(Code::STUB),

v8::internal::Handle<v8::internal::Object>(

- HEAP->undefined_value()))->ToObjectChecked());

+ isolate->heap()->undefined_value(), isolate))->ToObjectChecked());

Michael Starzinger 2013/02/25 10:50:58 Just use "isolate->factory()->undefined_value()" h

Sven Panne 2013/02/25 14:44:43 Done.

CHECK(code->IsCode());

F0 f = FUNCTION_CAST<F0>(code->entry());

« test/cctest/test-assembler-ia32.cc ('K') | « test/cctest/test-assembler-ia32.cc ('k') | test/cctest/test-compiler.cc » ('j') | test/cctest/test-disasm-ia32.cc » ('J')