src/code-stubs.cc - Issue 12300018: Made Isolate a mandatory parameter for everything Handle-related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs.cc

Issue 12300018: Made Isolate a mandatory parameter for everything Handle-related. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Even less Isolate::Current Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/code-stubs.cc

diff --git a/src/code-stubs.cc b/src/code-stubs.cc

index 5e3795ce69386d7ca7d3689d082a3e7cff16de93..95e725be90808d98ffc94db41d925a1749ca6e44 100644

--- a/src/code-stubs.cc

+++ b/src/code-stubs.cc

@@ -308,12 +308,10 @@ bool ICCompareStub::FindCodeInSpecialCache(Code** code_out, Isolate* isolate) {

static_cast<Code::Kind>(GetCodeKind()),

UNINITIALIZED);

ASSERT(op_ == Token::EQ || op_ == Token::EQ_STRICT);

- Handle<Object> probe(

- known_map_->FindInCodeCache(

- strict() ?

- *factory->strict_compare_ic_symbol() :

- *factory->compare_ic_symbol(),

- flags));

+ String* symbol = strict() ?

Michael Starzinger 2013/02/25 10:50:58 Drop one of the two white-spaces on the left-hand

Sven Panne 2013/02/25 14:44:43 Done.

+ *factory->strict_compare_ic_symbol() :

+ *factory->compare_ic_symbol();

+ Handle<Object> probe(known_map_->FindInCodeCache(symbol, flags), isolate);

if (probe->IsCode()) {

*code_out = Code::cast(*probe);

#ifdef DEBUG

« no previous file with comments | « src/bootstrapper.cc ('k') | src/code-stubs-hydrogen.cc » ('j') | src/debug.cc » ('J')